? Success
Pull Request for # 5834

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
28 Jan 2015

This PR relates to @brianteeman PR #5834

On fresh install, set a logical ordering of pre-defined access levels.

In com_users access levels view, list is order by ordering ASC.
This way, the ordering is the same by default in Access Levels view, in Access filter and select field.

Ref : #5834

avatar JoomliC JoomliC - open - 28 Jan 2015
avatar jissues-bot jissues-bot - change - 28 Jan 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 28 Jan 2015

Awesome - Do you think it should be
Public 0
Guest 1

You currently have it the otherway around


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5899.
avatar brianteeman brianteeman - change - 28 Jan 2015
Rel_Number 5834
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 28 Jan 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 28 Jan 2015
Easy No Yes
avatar JoomliC
JoomliC - comment - 28 Jan 2015
Do you think it should be Public 0 Guest 1

Oh yes you're right. Edited! ;-)

avatar brianteeman brianteeman - test_item - 28 Jan 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jan 2015

Awesome - thanks

On 28 January 2015 at 16:55, Cyril Rezé notifications@github.com wrote:

Do you think it should be Public 0 Guest 1

Oh yes you're right. Edited! ;-)


Reply to this email directly or view it on GitHub
#5899 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar wilsonge
wilsonge - comment - 29 Jan 2015

With this change how does the ordering look for existing sites. Is it now completely random?

avatar JoomliC
JoomliC - comment - 29 Jan 2015
With this change how does the ordering look for existing sites. Is it now completely random?

There will be no change in filter and access type dropdown. (as order by ordering ASC first, and after ordering by Title ASC).
So, for someone who has never changed ordering of access levels, it will change only in access levels view.
But, if someone has already changed ordering of access levels, to have the order he wanted in the filter or access field input, it won't change nothing! (this is why ordering should not be updated for already existing sites, to prevent to break user own ordering).

So, the only change in Access levels view, will be for someone who has never changed access ordering.
In all cases, no changes after update for already existing sites in filter and access type field.

It was before completely random where we really select access : filter and access type field. ;-)
On a fresh install, ordering will be logical by default everywhere, and customizable.
On an update, ordering will have to be set depending of user needs.

To keep before-update order in access levels, is it possible to add a second ordering to parent::populateState ?

avatar waader
waader - comment - 29 Jan 2015

Works with mysql, postgresql, mssql except when you install with the following data:

  • mysql: sample_learn.sql
  • postgresql: sample_learn.sql
  • mssql: sample_learn.sql and sample_testing.sql
avatar JoomliC
JoomliC - comment - 29 Jan 2015

@waader Thank you! :+1:
I didn't think of samples...

I have added ordering, but just a question about 'Customer Access Level (Example)' order.
I have ordered like this :

0 Public
1 Guest
2 Registered
3 Customer Access Level (Example)
4 Special
5 Super Users

Before, Customer Access Level was ordered after Special... was it an error ? Seems to me more logicial if Special is after Customer Access Level (Example)... ?

Cyril

avatar brianteeman
brianteeman - comment - 29 Jan 2015

Looks good to me

On 29 January 2015 at 12:08, Cyril Rezé notifications@github.com wrote:

@waader https://github.com/waader Thank you! [image: :+1:]
I didn't think of samples...

I have added ordering, but just a question about 'Customer Access Level
(Example)' order.
I have ordering like this :

0 Public
1 Guest
2 Registered
3 Customer Access Level (Example)
4 Special
5 Super Users

Before, Customer Access Level was ordered after Special... was it an error
? Seems to me more logicial if Special is after Customer Access Level
(Example)... ?

Cyril


Reply to this email directly or view it on GitHub
#5899 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 29 Jan 2015

:+1: @test ok (mysql)

avatar waader
waader - comment - 1 Feb 2015

@test works for mysql, postgresql, mssql! Thanks!

avatar waader waader - test_item - 1 Feb 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Feb 2015

Multiple tests RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5899.
avatar brianteeman brianteeman - change - 1 Feb 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 1 Feb 2015
Labels Added: ?
avatar phproberto phproberto - close - 7 Mar 2015
avatar zero-24 zero-24 - close - 7 Mar 2015
avatar phproberto phproberto - change - 7 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-07 02:25:47
avatar phproberto phproberto - close - 7 Mar 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment