Feeling Lucky
[#589] - [imp] Peters patch + backward compatibility fix
- Closed
- 6 Jan 2013
- Medium
- Build: master
- # 589
- Diff
- phproberto:27699
- Foreign ID 27699
User tests: Successful: Unsuccessful:
This patch includes the @nonumber patch for the item 27699 + a backward incompatibility fix:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27699
phproberto
- comment
- 4 Dec 2012
@jmcameron you are right. I changed all the contexts to use article instead of category & featured.
Thanks!
mbabker
-
jmcameron
- comment
- 6 Jan 2013
Wonderful!
jmcameron
- comment
- 16 Feb 2013
@phproberto Could you please test the parallel fix for Joomla 2.5.x: #647
Thanks
nonumber
- comment
- 16 Feb 2013
Looks fine to me :)
jmcameron
- comment
- 16 Feb 2013
@phproberto and Peter @nonumber, please add any comments, tests, etc regarding pull request #647 on that pull request since folks reviewing that pull request are not going to look at this closed pull request!
Thanks!
-Jonathan
I read through this patch and mostly like it except that I think that the context in all the callbacks in the loop in view.html.php should be changed to $context = 'com_content.article' since this loop is for displaying the articles under the category. BTW, the category callback is in tmpl/default.php.
Please read my notes in the comments for http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27699.
If this pull request is modified as I suggest, this bug fix (589) will make my pull request unnecessary (#509).
Thanks
-Jonathan