@test Works fine.

Old version:

New version:

Typo:
+PLG_RECAPTCHA_VERSION_DESC="Choose the reCaptcha version neede for your keys"

testing now.

@roland-d

I suggest to make it clearer that the new version (Version2 ?) does NOT accept Global keys.
Could be in the description or as a tip

I agree with with @infograf768

Perhaps
+PLG_RECAPTCHA_VERSION_1="1.0"
+PLG_RECAPTCHA_VERSION_1_DESC="Required if using Global CAPTCHA keys."
+PLG_RECAPTCHA_VERSION_2="2.0"
+PLG_RECAPTCHA_VERSION_2_DESC="Recommended version."

@test Success

In detail:

• Version 1.0 with global key: works as expected
• Version 1.0 with site key: works as expected
• Version 2.0 with global key: ReCAPTCHA complains about wrong key or domain as expected
• Version 2.0 with site key: works as expected

Tested with front-end user registration and com_contact.

@test
Works fine here.

Just needs the improvements for the versions and we can merge, as we freeze langs tomorrow

Seems a bit weird that version 2.0 is the 'Recommended version.', but version 1.0 is the default active one.

Thanks for testing everybody. I have updated the language files and believe they are good now.
@brianteeman I can't do a language string per version, so I have combined both into one.
Please check if all is OK now.

@nonumber Having read the past discussions, this strange default value seems to spring from the need to have a continuity for people using global keys. Version 2 API doesn't support global keys. If version 2 was the default, sites using global keys upgrading to Joomla! 3.4 would no longer have a functioning ReCAPTCHA misleading users into believing that Joomla! 3.4 is "broken". I'm not a fan of this default value either, but it's the only compromise solution to cater for the people who don't read the release notes, i.e. virtually everybody using Joomla!.

OK for me

@nonumber
I guess this is for B/C reasons

Indeed that 1.0 is the default value, only reason is for backwards compatibility reasons. Those using global keys would on update have a broken reCAPTCHA. This way we ensure that keeps working.

@roland-d I would go with @wilsonge comment about stating that v1 is deprecated

Updated the strings again :)

Can we show a deprecated warning in the module parameter view when v1 is selected or the version param is not yet saved? Could be done simple with a dummy formfield above the version field and the showon feature.
This way people would clearly see that they should choose v2 and it would solve the issue with the "wrong" default value (which we correctly have for BC reasons).

@Bakual Thanks on the theme parameter. It's fixed now. As for showing the message, that is fine by me. Just need to know what the text needs to be :)

@nonumber Thanks for the suggestion, I have cleaned up the code per your suggestion.

Nice

As for showing the message, that is fine by me. Just need to know what the text needs to be :)

Would need input from @brianteeman, but I would do something like "You have selected the deprecated version of this plugin. It's recommended to select version 2. Make sure you have supported keys for that version before switching."

Displaying a message is good but I think the tone and meaning of that proposed text is not right.

I think it needs to say something like
"You have selected Version 1. All new sites should be using Version 2. Version 1 is only maintained to provide support for Global Site keys which are no longer available from Google."

Is it all good now or do we need more language updates?

All good to me - thanks

Thanks for testing and review moving to RTC based on various tests. Thanks!

Thanks. Merged after correcting also the installation sql files and en-GB.install.xml

I want to work on it for Joomla but I am too late.

Still I have submitted new plugin on JED for reCaptcha2. Now I am finding new stuff for Joomla.