[#5873] - Convert users notes modal to Bootstrap modal
- Closed
- 29 Jan 2015
- Medium
- Build: staging
- Easy Test
- # 5873
- Diff
- dgt41:_User_note_modal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Convert users notes mootools modal to BS modal
In users list view (/administrator/index.php?option=com_users&view=users), there is still a mootools modal. Needs some notes to reveal it!
This PR converts it to Bootstrap modal
Preview:
Testing
Create some user notes (/administrator/index.php?option=com_users&view=notes)
Apply patch
go to (/administrator/index.php?option=com_users&view=users) and click "display 1 note"
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration |
| Easy | No | ⇒ | Yes |
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing and coding here! Moving to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5873.
Thanks for testing. @wilsonge @phproberto 3.5?
It's good for 3.4 (no layouts involved) but I'm not merging anything more until i release beta 1 tonight
brianteeman
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-29 01:18:22 |
Merged this. Thanks!
@wilsonge
We can use this code:
// Also skip for the component output
$tmpl = JFactory::getApplication()->input->getCmd('tmpl', '');
if (isset($tmpl) && $tmpl == 'component')
{
return;
}here: https://github.com/joomla/joomla-cms/blob/staging/plugins/system/debug/debug.php#L120
But I don’t know if we need an option in the plugin as well, any thoughts?
The problem is in some frontend areas people render component only output and will expect debug to show :/ so i don't think it's that easy to do it for all component only views
I think it needs to be controlled in the plugin somehow. Front end, back end will also make some devs unhappy… I am not sure also, maybe raising an issue and get some feedback?
| Labels |
Removed:
?
|
||
@test All good!