? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
21 Jan 2015

Similar to #5835

After patch, we will get

screen shot 2015-01-21 at 08 31 16

and

screen shot 2015-01-21 at 08 30 59

avatar infograf768 infograf768 - open - 21 Jan 2015
avatar jissues-bot jissues-bot - change - 21 Jan 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 21 Jan 2015

Note: similar patches can be done in many managers.

avatar brianteeman brianteeman - change - 21 Jan 2015
Category Templates (admin)
avatar brianteeman
brianteeman - comment - 21 Jan 2015

Do we really need to create some of these tooltips. I know its the author because it is in the author column. Adding a tooltip to remind me of that 20 times on the page doesnt help it just clutters


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5844.
avatar infograf768
infograf768 - comment - 22 Jan 2015

The title="<?php echo JText::_('JACTION_EDIT'); ?>" already exists in the code and the tooltip displayed is not conform
It displays in black over yellow as it was here before patch

capture

This ONLY adds the right class to the link to display white text on black background.

If you consider that these are unnecessary, the title and author (and maybe others) should be removed all over the back-end.

avatar Bakual
Bakual - comment - 22 Jan 2015

I agree it should be either a proper tooltip like JM suggests or completely remove it if deemed unnecessary.

avatar brianteeman
brianteeman - comment - 22 Jan 2015

I agree that this should be a proper tooltip

I dont agree with adding tooltips to things that dont already have them (or
need them)

For this specific one I only agree it needs something because the icons
used are not consistent with the UI and are not easy to understand. I would
prefer they were changed completely but for speed and a first step I agree
in changing to a proper tooltip

On 22 January 2015 at 09:08, Thomas Hunziker notifications@github.com
wrote:

I agree it should be either a proper tooltip like JM suggests or
completely remove it if deemed unnecessary.


Reply to this email directly or view it on GitHub
#5844 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar wilsonge
wilsonge - comment - 1 Feb 2015

I agree that we should probably consistently remove these 'useless' tooltips. But for consistency merging this.

@test works fine

avatar wilsonge wilsonge - close - 1 Feb 2015
avatar wilsonge wilsonge - change - 1 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-01 16:30:51
avatar wilsonge wilsonge - test_item - 1 Feb 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Feb 2015

Why are you merging something that you say is useless. If you want
consistency, and we all do, then remove the other useless tooltips dont add
more. This makes no sense at all

On 1 February 2015 at 16:30, George Wilson notifications@github.com wrote:

Merged #5844 #5844.


Reply to this email directly or view it on GitHub
#5844 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar wilsonge
wilsonge - comment - 1 Feb 2015

I personally don't have the time to go through and remove all these tooltips and in the meantime this PR has sat here for 11 days with no alternatives being submitted (and it's not like it's a big b/c thing where it can't be easily reverted next release). If you want to spend some time doing the PR then feel free else I'm going to go for consistency.

Add a Comment

Login with GitHub to post a comment