?
avatar dgt41
dgt41
20 Jan 2015
This regards the css changes made with #4575

It seems that the changes in PR #4575 have some negative results on 3PD code

Some insight from my point of view and the reason I decided to change the width of the modals:

First of all that PR was part of a series of PRs {#4513 #4514 #4561 #4562 #4563} that tried to convert most of the mootools modals to use the bootstrap code. The problem that I faced in the process was the width of the modal, which was defined to some predefined pixels [width: 580px;] and that made a lot of the modals look really weird. There were two options to solve this problem:
1 Define some css values every time a modal needed some space, see here
2 Make the initial modal values bigger so that can accommodate any iframe size, started here

Initially I followed the first path, but somewhere along the way I switched to editing the bootstrap modal less file and so a predefined width: 80%; came along.

Since all the bootstrap modals, also in this case, is uniquely named (class="multiLangModal") I propose to either
add the style overrides directly to the template.less of isis and hathor
OR
use define (add some) styles when the modal is generated

PLT please advise what will be the best solution for this and I will provide the changes.

avatar dgt41 dgt41 - open - 20 Jan 2015
avatar jissues-bot jissues-bot - change - 20 Jan 2015
Labels Added: ?
avatar 810
810 - comment - 25 Jan 2015

Any news?

avatar dgt41 dgt41 - change - 5 May 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-05-05 13:37:00
Closed_By dgt41
avatar dgt41 dgt41 - close - 5 May 2015

Add a Comment

Login with GitHub to post a comment