J4 Issue ? ?
avatar nternetinspired
nternetinspired
19 Jan 2015

A thought relating to #5803, are we confusing 'State' with 'Status' and combining the two in the UI when they should not be combined?

Currently we lump together published/unpublished, archived/not-archived, featured/not-featured and trashed/not-trashed but it seems to me that only published/unpublished is a state, the others are more like special categories (statues) because an article can exist both with a state and a status.

For example an article can be featured and unpublished, and the same is true of archived articles. Trashed is a bit different, as you can't publish/unpublish a trashed article.

avatar nternetinspired nternetinspired - open - 19 Jan 2015
avatar jissues-bot jissues-bot - change - 19 Jan 2015
Labels Added: ?
avatar jissues-bot jissues-bot - change - 19 Jan 2015
Labels Added: ?
avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

I would suggest that we therefore redefine these as:

State: published / unpublished / trashed
Status*: featured / archived

  • or another, more appropriate, name.
avatar brianteeman
brianteeman - comment - 19 Jan 2015

Sounds good but I would assume we need a status for an item that is not
featured or archived as well

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

Sounds good but I would assume we need a status for an item that is not
featured or archived as well

I don't think so, because not-featured and not-archived are both equal to the default status of an article.

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

And throughout the UI we already have the syntax to support that. For example, when viewing featured articles the toolbar option reads 'unfeature'. The same is true in the trashed article view.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

I guess it depends on how it is displayed.

In general I agree with what you are saying

avatar brianteeman
brianteeman - comment - 19 Jan 2015

How would this be displayed?

One change we can make right now is to change strings like these from
COM_CONTACT_TOGGLE_TO_FEATURE="Toggle to change contact state to 'Featured'"
COM_CONTACT_TOGGLE_TO_UNFEATURE="Toggle to change contact state to 'Unfeatured'"
to
COM_CONTACT_TOGGLE_TO_FEATURE="Toggle to change contact status to 'Featured'"
COM_CONTACT_TOGGLE_TO_UNFEATURE="Toggle to change contact status to 'Unfeatured'"

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Featured and archived are different in the database

Featured is its own column

Archived is a value of 2 in the State column

So I can see how we can change Featured to be status - its just a language string but archived is different (Or do i misunderstand part of what you are saying)

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

I'd even cut it to just:

COM_CONTACT_TOGGLE_TO_FEATURE="Toggle contact 'Featured' status"

Then the UNFEATURE strings are no longer needed then.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

What about using a generic string
JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click on icon to toggle status."

On 19 January 2015 at 10:55, Seth Warburton notifications@github.com
wrote:

I'd even cut it to just:

COM_CONTACT_TOGGLE_TO_FEATURE="Toggle contact 'Featured' status"

Then the UNFEATURE strings are no longer needed then.


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Thats an easy change to make

On 19 January 2015 at 10:57, Brian Teeman brian@teeman.net wrote:

What about using a generic string
JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click on icon to toggle status."

On 19 January 2015 at 10:55, Seth Warburton notifications@github.com
wrote:

I'd even cut it to just:

COM_CONTACT_TOGGLE_TO_FEATURE="Toggle contact 'Featured' status"

Then the UNFEATURE strings are no longer needed then.


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

So I can see how we can change Featured to be status - its just a language string but archived is different

You're right! I was under the (false) impression that an archived item could also be unpublished, I see now it can't. That said I do still think that 'archived' as a state is illogical. While it may be architected differently, it probably shouldn't be. I think it would make more sense as a kind of special status like featured.

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click on icon to toggle status."

A generic string would be even better, I agree. What about simply:

JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click to toggle item status."

avatar brianteeman
brianteeman - comment - 19 Jan 2015

So lets do one thing at a time. As it looks to me like we need to also
change the way featired is displayed in the contact list to be consistent
with the article list.

I will do a PR now to use JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click to toggle
item status."

On 19 January 2015 at 11:01, Seth Warburton notifications@github.com
wrote:

So I can see how we can change Featured to be status - its just a language
string but archived is different

You're right! I was under the (false) impression that an archived item
could also be unpublished, I see now it can't. That said I do still think
that 'archived' as a state is illogical. While it may be architected
differently, it probably shouldn't be. I think it would make more sense as
a kind of special status like featured.


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

I will do a PR now to use JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click to toggle
item status."

:+1:

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Actually just looked at it and as the layouts are different in the two
places this is used (articles and contacts) I think it is going to be
better to have

JGLOBAL_TOGGLE_FEATURED_STATUS="Toggle featured status."

(I dont like using the word click)

On 19 January 2015 at 11:10, Seth Warburton notifications@github.com
wrote:

I will do a PR now to use JGLOBAL_CLICK_TO_TOGGLE_STATUS="Click to toggle
item status."

[image: :+1:]


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 19 Jan 2015

Archived IS a state, not Featured

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

JGLOBAL_TOGGLE_FEATURED_STATUS="Toggle featured status."

Even better. I agree, I also don't like click.

Archived IS a state, not Featured

Yes, I realise that now. I don't think that is very intuitive though, so my question now is whether it would be better implemented as a status like 'featured' in future.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Re Archived

Thats a bigger change

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

I agree.

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

Can we all agree that featured is not a state though?

If we can then it has implications here:#5803

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Please see and test #5823

On 19 January 2015 at 11:21, Seth Warburton notifications@github.com
wrote:

I agree.


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 19 Jan 2015

I agree that featured is not a state either architecturally or logically

On 19 January 2015 at 11:22, Seth Warburton notifications@github.com
wrote:

Can we all agree that featured is not a state though?

If we can then it has implications here:#5803
#5803


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

I've just noticed that com_contact does not mix featured into the status column. I think it's far better the way it is done in com_contact that con_content:

screen shot 2015-01-19 at 11 29 02

avatar brianteeman
brianteeman - comment - 19 Jan 2015

I was thinking the complete opposite

On 19 January 2015 at 11:30, Seth Warburton notifications@github.com
wrote:

I've just noticed that com_contact does not mix featured into the status
column. I think it's far better the way it is done in com_contact that
con_content:

[image: screen shot 2015-01-19 at 11 29 02]
https://cloud.githubusercontent.com/assets/1090182/5799806/8ec69232-9fce-11e4-9b97-836c2d7c905a.png


Reply to this email directly or view it on GitHub
#5819 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

Status, as we currently have it, is a sortable column that mixes both logical publication states and the featured status. They don't belong in the same column.

Related: the search tools filter allows you to filter by published/trashed/archived but not featured. That is correct IMO.

avatar zero-24 zero-24 - change - 19 Jan 2015
Category Language & Strings
avatar zero-24 zero-24 - change - 8 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 8 May 2015
Labels Added: ?
avatar photodude
photodude - comment - 21 Dec 2015

I agree with this change.

avatar brianteeman brianteeman - change - 28 Jan 2016
Status New Needs Review
Labels
avatar wilsonge
wilsonge - comment - 12 Apr 2016

OK we can't change archive to be like featured until at least J4 - because it's a big b/c change. You can if you want make UX changes for 3.6 to separate featured from the status'

Removing from the needs review pile

avatar wilsonge wilsonge - change - 12 Apr 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 12 Apr 2016
Status Needs Review Confirmed
avatar wilsonge wilsonge - change - 12 Apr 2016
Status Confirmed New
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 May 2016

i also agree with feature not being in the states column

avatar brianteeman brianteeman - change - 28 Jul 2016
Status New Discussion
avatar rdeutz rdeutz - change - 17 Aug 2016
Labels Added: ?
avatar marcochirienti
marcochirienti - comment - 15 Mar 2017

I agree with "featured status" not being in the ''state" column.
And I think that the use of the words "state", "status", and "spublished" should be "standardized" in J4.
Actually there are, for similar purpose, columns with different names in different tables (state or published).
Filters are of type "status" and with name "published".
Language labels use "STATE" or "STATUS" are used interchangeably.

avatar brianteeman
brianteeman - comment - 14 May 2017

Updated the title to show 4.0

avatar brianteeman brianteeman - edited - 14 May 2017
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar brianteeman
brianteeman - comment - 10 Apr 2018

Closing this as we now have a new ui under development

avatar brianteeman brianteeman - close - 10 Apr 2018
avatar brianteeman brianteeman - change - 10 Apr 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-04-10 12:52:44
Closed_By brianteeman
Labels Added: J4 Issue

Add a Comment

Login with GitHub to post a comment