? Success
Pull Request for # 5773

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
18 Jan 2015

PR for #5773

Changes in Extensions > Modules > Banner > "Count" option from
drop down box with values 1 to 10 (integer)
to free input field (text).

avatar pe7er pe7er - open - 18 Jan 2015
avatar jissues-bot jissues-bot - change - 18 Jan 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 18 Jan 2015
Category Modules
avatar dgt41
dgt41 - comment - 18 Jan 2015

It needs to validate only for integers (I think just adding class="validate-number" will do the trick)

avatar dgt41
dgt41 - comment - 18 Jan 2015

class="validate-numeric" is the right one!

avatar dgt41
dgt41 - comment - 18 Jan 2015

@pe7er you have a PR for that!

avatar pe7er
pe7er - comment - 18 Jan 2015

Great catch @dgt41!
Thanks!

avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Jan 2015

@pe7er Please also add a server side check with filter="integer". Thank you!

avatar pe7er
pe7er - comment - 18 Jan 2015

Ok, done. Thanks @Kubik-Rubik

avatar Kubik-Rubik Kubik-Rubik - test_item - 18 Jan 2015 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Jan 2015

Works as described! One more tester please.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5804.

avatar dgt41
dgt41 - comment - 18 Jan 2015

@test OK!

avatar Kubik-Rubik Kubik-Rubik - alter_testresult - 18 Jan 2015 - dgt41: Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Jan 2015

Thank you for testing it @dgt41!

avatar Kubik-Rubik Kubik-Rubik - reference | 226b22d - 18 Jan 15
avatar Kubik-Rubik Kubik-Rubik - merge - 18 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - close - 18 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - close - 18 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - change - 18 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-18 02:35:58
avatar Kubik-Rubik Kubik-Rubik - change - 18 Jan 2015
Milestone Added:
avatar brianteeman brianteeman - change - 18 Jan 2015
Rel_Number 5773
Relation Type Pull Request for
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment