User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-16 12:41:47 |
Status | Closed | ⇒ | New |
Status | New | ⇒ | Pending |
@test success!
Before PR, categories were not filtered by language.
PR tested with multi-language enabled, and with those settings :
Menus (Type: category list or category blog) :
1. Menu LANG_1 -> CAT_LANG1
2. Menu LANG_2 -> CAT_LANG2
3. Menu LANG3 -> CAT_LANG2
Results with PR :
1. CAT_LANG1 + SUB_CAT_LANG1
2. CAT_LANG2 (no subcategory displayed each time a parent is not in current language)
3. error 404 "Category not found"
So, all is good!
Note that about 3, i will check this week-end (or if another person is looking at it already...) if possible to add a checking when saving a menu, to prevent to be able to save a menu if menu language is not the same as the category's language selected.
Cyril
Will test later.
Status | Pending | ⇒ | Closed |
Closed_Date | 2015-01-16 12:41:47 | ⇒ | 2015-01-19 10:09:41 |
I came across with another issue related to category language filter. The Language switcher module uses path helper to compute associated URLs. Since inactive languages are now filtered out the URLs for category views cannot be computed this way. Moreover path helper always loads complete category views for all languages which is wasteful because users usually do not switch to different languages while browsing.
I suggest PR #5817 to fix this issue. It uses patch #5756 (which is now closed) and some more files patched. No more category path helper called. Category objects for inactive languages are not loaded anymore.
I suggest this patch to solve issues
#5734
#5740