? Success
Pull Request for # 5750

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
16 Jan 2015

see: #5750

-Go to extension manager>Install Languages
-Search an invalid keyword
-Ideally, application should display a message 'No matching Results'

screen shot 2015-01-16 at 03 35 49screen shot 2015-01-16 at 03 35 54

avatar zero-24 zero-24 - open - 16 Jan 2015
avatar jissues-bot jissues-bot - change - 16 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 16 Jan 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 16 Jan 2015
Rel_Number 5750
Relation Type Pull Request for
Easy No Yes
avatar pe7er
pe7er - comment - 16 Jan 2015

In your screenshot "No Matching Results" is in red, and you have the search field.

On my system (3.4dev), after the search for a non existing language,
the "No Matching Results" is in yellow,
and the Search Field + Name/Version/Type/Details is missing:
extension manager - install languages

avatar pe7er
pe7er - comment - 16 Jan 2015

@test
I've tested your new patch and that works great!

avatar zero-24
zero-24 - comment - 16 Jan 2015

sorry @pe7er this is fixed now :smile:

new_fix

avatar zero-24
zero-24 - comment - 16 Jan 2015

now we don't have the table headings. oops sorry for the german scrennshot here is the english:

new_fix_engl

avatar waader
waader - comment - 16 Jan 2015

@test works!

avatar waader waader - test_item - 16 Jan 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Jan 2015

Thanks @waader can you retest @pe7er ?

avatar infograf768
infograf768 - comment - 16 Jan 2015

This works fine but imho needs correcting formatting.
@zero-24
I made a patch for that including your changes towards staging.
code:

diff --git a/administrator/components/com_installer/views/languages/tmpl/default.php b/administrator/components/com_installer/views/languages/tmpl/default.php
index 9446eb1..d607c0f 100644
--- a/administrator/components/com_installer/views/languages/tmpl/default.php
+++ b/administrator/components/com_installer/views/languages/tmpl/default.php
@@ -30,7 +30,11 @@
        <div id="j-main-container">
    <?php endif;?>
-
-       <?php if (count($this->items) || $this->escape($this->state->get('filter.search'))) : ?>
-           <?php echo $this->loadTemplate('filter'); ?>
+   <?php if (count($this->items) || $this->escape($this->state->get('filter.search'))) : ?>
+       <?php echo $this->loadTemplate('filter'); ?>
+       <?php if (empty($this->items)) : ?>
+           <div class="alert alert-no-items">
+               <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
+           </div>
+       <?php else : ?>
            <table class="table table-striped">
                <thead>
@@ -64,6 +68,5 @@
                </tfoot>
                <tbody>
-                   <?php foreach ($this->items as $i => $language) :
-               ?>
+               <?php foreach ($this->items as $i => $language) : ?>
                    <tr class="row<?php echo $i % 2; ?>">
                        <td class="center">
@@ -94,10 +97,11 @@
                        </td>
                    </tr>
-                   <?php endforeach; ?>
+               <?php endforeach; ?>        
                </tbody>
            </table>
-       <?php else : ?>
-           <div class="alert"><?php echo JText::_('COM_INSTALLER_MSG_LANGUAGES_NOLANGUAGES'); ?></div>
        <?php endif; ?>
+   <?php else : ?>
+       <div class="alert"><?php echo JText::_('COM_INSTALLER_MSG_LANGUAGES_NOLANGUAGES'); ?></div>
+   <?php endif; ?>

            <input type="hidden" name="task" value="" />

avatar zero-24
zero-24 - comment - 16 Jan 2015

should be ok now Thanks @infograf768

avatar infograf768 infograf768 - close - 16 Jan 2015
avatar infograf768 infograf768 - change - 16 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-16 12:03:07
avatar infograf768
infograf768 - comment - 16 Jan 2015

Fixed a bit more and merged. Thanks!

avatar zero-24
zero-24 - comment - 16 Jan 2015

Thanks @infograf768 can you remove also this line?
e9d179f#diff-2a269d0642e99207e237b2301e44178aR106

avatar infograf768
infograf768 - comment - 16 Jan 2015

Thanks @infograf768 can you remove also this line?
e9d179f#diff-2a269d0642e99207e237b2301e44178aR106

We usually leave a blank line before <input type="hidden" etc. although it is not done in some places.

avatar zero-24
zero-24 - comment - 16 Jan 2015

thanks.

Add a Comment

Login with GitHub to post a comment