? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
15 Jan 2015

See: Extensions > Module Manager > Articles Related Items > Advanced
There's a "Caching" option available but "Cache Time" field is missing.
This PR adds a "Cache Time" field.

avatar pe7er pe7er - open - 15 Jan 2015
avatar jissues-bot jissues-bot - change - 15 Jan 2015
Labels Added: ?
avatar pe7er
pe7er - comment - 15 Jan 2015

"Cache Time" field is missing
administration - module manager module articles - related articles

This PR adds a "Cache Time" field.
administration - module manager module articles - related articles fixed

avatar brianteeman brianteeman - change - 15 Jan 2015
Category Modules
avatar brianteeman brianteeman - change - 15 Jan 2015
Category Modules Cache Modules
avatar waader
waader - comment - 16 Jan 2015

Maybe a dumb question. When adding this field, is the use of this field ensured?

avatar pe7er
pe7er - comment - 16 Jan 2015

Thanks for your response. Not a dump question at all...

The caching of Modules is handled by /libraries/cms/module/helper.php

Another Module, Articles Categories, had the same "<field name="owncache" for "Caching" drop down option AND "<field name="cache_time" for "Cache Time".
See /modules/mod_articles_categories/mod_articles_categories.xml

This Articles Related Items Module had the "<field name="owncache" for "Caching" drop down option but was missing the field for "Cache Time". This patch uses the same code as Articles Categories, so it should work. I haven't tested the actual caching (of the other Articles Categories and Articles Related Items plus this patch) myself.

When testing the patch, please also test the caching itself,
and not only the appearance of the field in the back-end.

avatar waader
waader - comment - 16 Jan 2015

@test works! Cache time is "processed".

Thanks pe7er!

avatar Kubik-Rubik
Kubik-Rubik - comment - 17 Jan 2015

Thank you for the PR, @pe7er and @waader for testing!

avatar Kubik-Rubik Kubik-Rubik - close - 17 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - reference | bf35ff0 - 17 Jan 15
avatar Kubik-Rubik Kubik-Rubik - merge - 17 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - close - 17 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - change - 17 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-17 16:03:59
avatar Kubik-Rubik Kubik-Rubik - change - 17 Jan 2015
Milestone Added:
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment