[#5723] - Added the missing a close tag
- Closed
- 15 Jan 2015
- Medium
- Build: staging
- Easy Test
- # 5723
- Diff
- rdeutz:fix-miss-a-tag-in-contenthistory-modal
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Added the missing a close tag
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
| Status | Ready to Commit | ⇒ | Pending |
moving back to pending as the missing line that was find by @Hackwar
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5723.
brianteeman
- | Labels |
Added:
?
|
||
How I get this fixed? I did a commit with an empty line (amend) it with the one I already did. In my branch the file has 193 lines so there is a new line at the end of the file. If I delete the local file and pull from my branch I get a file with an empty line at the end. So anything looks fine. Does github not showing the empty line at the end of the file?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5723.
It's okay the way it is. If there is no linebreak after the last command, github shows a red error behind the last command. So this is fixed and ready to be merged.
| Status | Pending | ⇒ | Ready to Commit |
Thanks @Hackwar moving back to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5723.
roland-d
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-15 20:07:57 |
| Labels |
Removed:
?
|
||
@test success via codereview. Could you please add one empty line at the end of the file?