Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5720] - Correct PHP strict error in JMediawikiHttp

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
14 Jan 2015

The method declarations in JMediawikiHttp, a subclass of JHttp, do not match up and causes PHP strict errors. This PR updates the subclass to have the correct declarations and implements similar handling of the param as exists in the parent classes.

Testing Instructions

The only way I can think to directly test this with the CMS repo is to run the build/helpTOC.php CLI script. Pre-patch, you'll get strict standards messages; post-patch, you won't.

avatar mbabker mbabker - open - 14 Jan 2015
avatar jissues-bot jissues-bot - change - 14 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 14 Jan 2015
Category ⇒ Libraries
avatar waader
waader - comment - 14 Jan 2015

@test works as described!

avatar waader waader - test_item - 14 Jan 2015 - Tested successfully
avatar wilsonge wilsonge - close - 14 Jan 2015
avatar wilsonge wilsonge - reference | e8f3d6a - 14 Jan 15
avatar wilsonge wilsonge - merge - 14 Jan 2015
avatar wilsonge wilsonge - close - 14 Jan 2015
avatar wilsonge wilsonge - change - 14 Jan 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-01-14 20:24:11
avatar wilsonge wilsonge - change - 14 Jan 2015
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 14 Jan 2015

Add a Comment

Login with GitHub to post a comment