? ? Success

User tests: Successful: Unsuccessful:

avatar J0WI
J0WI
13 Jan 2015

Referring to #5478 (comment)

I split this in multiple commits. Most changes are comments and sample data.
I also changed the links in /tests now.

avatar J0WI J0WI - open - 13 Jan 2015
avatar jissues-bot jissues-bot - change - 13 Jan 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 14 Jan 2015
Category Code style
avatar brianteeman
brianteeman - comment - 14 Jan 2015

As far as I can see this is all ok as @mbabker has stated that the docs site is now on https


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5717.

avatar brianteeman brianteeman - test_item - 14 Jan 2015 - Tested successfully
avatar mbabker
mbabker - comment - 14 Jan 2015

Looks fine to me.

For those looking at this PR and thinking "it's just doc blocks, why does it matter?", the doc blocks are utilized to generate the content for our API site. One of the files changed in this case is the JLayout interface, which is listed at https://api.joomla.org/cms-3/classes/JLayout.html. Note the link in the class info block.

avatar brianteeman
brianteeman - comment - 15 Jan 2015

Setting to RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5717.

avatar brianteeman brianteeman - change - 15 Jan 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 15 Jan 2015
Labels Added: ?
avatar anibalsanchez anibalsanchez - test_item - 15 Jan 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 15 Jan 2015

@test OK

I has applied it and I have been working on the patched site. All links go to https://docs.joomla.org/


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5717.

avatar rdeutz rdeutz - close - 15 Jan 2015
avatar zero-24 zero-24 - close - 15 Jan 2015
avatar rdeutz rdeutz - change - 15 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-15 21:44:30
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment