Feeling Lucky
?
[#5713] - Standardise on break in php - code style
- Closed
- 14 Jan 2015
- Medium
- Build: staging
- # 5713
- Diff
- brianteeman:break-standardise
- Success The Travis CI build passed Details
Pull Request for
# 5711
User tests: Successful: Unsuccessful:
Standardise on using <br /> in our code as discussed #5711
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Title |
|
||||||
| Rel_Number | ⇒ | 5711 | |||||
| Relation Type | ⇒ | Pull Request for | |||||
| Title |
|
||||||
brianteeman
- comment
- 13 Jan 2015
thanks - cant see any other way to really test other than a code review so
can this be RTC
On 13 January 2015 at 20:26, Robert Deutz notifications@github.com wrote:
Did a code review and it looks good to me!
—
Reply to this email directly or view it on GitHub
#5713 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Status | Pending | ⇒ | Ready to Commit |
rdeutz
- comment
- 13 Jan 2015
The person who is doing the merge will check it again, it is so simple so this should be enough.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5713.
| Labels |
Added:
?
|
||
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-14 00:40:17 |
wilsonge
- comment
- 14 Jan 2015
Merged. Thanks
| Labels |
Removed:
?
|
||
Did a code review and it looks good to me!