[#5698] - Fix for Page Navigation Plugin on User Auth View
- Closed
- 13 Jan 2015
- Medium
- Build: staging
- # 5698
- Diff
- pe7er:patch-3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fix for issue: #5685 (see that issue for testing instruction)
The Article Pagination "Prev" & "Next" used the current article's Access Level (with "AND a.access = ' . (int) $row->access)") to navigate among articles within the same Category. That caused problems with Articles from the same Category that had different Access Levels.
This fix checks the User's authorized Access Levels (with "AND a.access IN ('.implode(",", JAccess::getAuthorisedViewLevels($user->id)).') ')" instead.
Note: using "IN" in SQL queries might be slower than "equal". I have not tested this fix on categories with huge numbers of articles!
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Rel_Number | ⇒ | 5685 | |
| Relation Type | ⇒ | Pull Request for |
Ah, I noticed the Travis error but did not know the cause.
Thanks Robert!
Thank you @pe7er, this PR fixes the problem.
I will merge the PR and close it!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5698.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-13 14:15:03 |
Great! Thank you all for testing!
| Milestone |
Added: |
||
You forget to make spaces before and after "." could you fix that to make travis happy, Thanks :-)