[#5696] - Fix alignment of number of hits under Hits column
- Closed
- 14 Jan 2015
- Medium
- Build: staging
- # 5696
- Diff
- pe7er:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If you change the width of the JGLOBAL_HITS from 10% to 1%, the alignment of the Hits column looks better.
Fix for #5658
jissues-bot
- | Labels |
Added:
?
|
||
| Rel_Number | ⇒ | 5658 | |
| Relation Type | ⇒ | Pull Request for |
Scrub that idea
The problem form what I can see is that the header and the data are aligned center
I would have thought that the numbers were easier to read if they were aligned left or right. Its definitely more normal for columns of numerical data to be aligned right than centered
You need to test with data longer than one or two digits eg hits of 12345
I tested the Hits field with the number 1,000,000 :-)
Agreed, alignment to the right of Header + hits number in the rows sounds good.
The comment about the number of hits was for testers ;)
On 13 Jan 2015 00:59, "Peter Martin" notifications@github.com wrote:
I tested the Hits field with the number 1,000,000 :-)
Agreed, alignment to the right of Header + hits number in the rows sounds
good.—
Reply to this email directly or view it on GitHub
#5696 (comment).
Nice job guys :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5696.
| Status | Pending | ⇒ | Ready to Commit |
@test: all good. Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5696.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-14 12:06:20 |
Dont you think it is better to just center align the heading
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5696.