? ? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
11 Jan 2015

Continuing the JInstallerAdapter implementations and standardizing the adapter paths, this PR focuses in on the update path.

This PR mainly alters the logic for the component updates; every other adapter modified had already used this standard path. Again, the language adapter is excluded and the library adapter is not modified either because of its approach to updates right now.

Also fixed with this PR is a regression in the uninstall route where the uninstall queries were not being run.

Testing Instructions

The path now always follows the install route (which was being done for all extensions but components) and the internal code determines which actions to perform based on the active route. Since some of the shared component methods are updated to accommodate for the update route, you'll want to install extensions first. To test updates, you'll want to use a release that isn't the latest one for optimal testing. After confirming everything still installs OK, you'll want to update the extension now, and this should be done using any regular update method. The extensions should update correctly.

Now try to uninstall your test extensions. If they have uninstall queries (many components do), ensure those queries get executed.

avatar mbabker mbabker - open - 11 Jan 2015
avatar jissues-bot jissues-bot - change - 11 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 11 Jan 2015
Category Libraries
avatar zero-24
zero-24 - comment - 13 Jan 2015

Travis fails here but it looks more on a issue on the travis side:
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

https://travis-ci.org/joomla/joomla-cms/jobs/46886733

maybe we cen restart the jobs here?

avatar wilsonge
wilsonge - comment - 13 Jan 2015

Restarted

avatar thinkerytim
thinkerytim - comment - 14 Jan 2015

Worked for me!

avatar zero-24 zero-24 - alter_testresult - 14 Jan 2015 - thinkerytim: Tested successfully
avatar waader
waader - comment - 14 Jan 2015

@test success! All problems I encountered do exist without this patch.

avatar waader waader - test_item - 14 Jan 2015 - Tested successfully
avatar zero-24 zero-24 - change - 14 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 14 Jan 2015

moving to RTC or do we need need more tests here bevor we can move it to RTC? @mbabker


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5677.
avatar zero-24 zero-24 - change - 14 Jan 2015
Milestone Added:
avatar brianteeman brianteeman - change - 14 Jan 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 16 Jan 2015

Thanks. Merging.

avatar zero-24 zero-24 - close - 16 Jan 2015
avatar infograf768 infograf768 - close - 16 Jan 2015
avatar infograf768 infograf768 - change - 16 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-16 12:56:54
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment