? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
11 Jan 2015

see: #5628

This is a proposal UI/UX review on mobile for the redirect component.

Bevor this Patch

mobile_com_redirect_bevor

After this Patch

mobile_com_redirect_after

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar zero-24 zero-24 - open - 11 Jan 2015
avatar jissues-bot jissues-bot - change - 11 Jan 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 11 Jan 2015

I think there is a bigger UI problem with this component and it effects all
resolutions.

If the plugin is running then it will end up capturing lots of crazy long
URLs that we dont wrap. I would look at the PR that @philetaylor mad to
etap crazy long article titles
On 11 Jan 2015 01:05, "zero-24" notifications@github.com wrote:

see: #5628 #5628

This is a proposal UI/UX review on mobile for the redirect component.
Bevor this Patch

[image: mobile_com_redirect_bevor]
https://cloud.githubusercontent.com/assets/2596554/5693912/db4bc108-9935-11e4-90c7-3271720ff266.PNG
After this Patch

[image: mobile_com_redirect_after]

https://cloud.githubusercontent.com/assets/2596554/5693918/30afbe24-9936-11e4-9407-be6ba6049df7.PNG

You can merge this Pull Request by running

git pull https://github.com/zero-24/joomla-cms patch-13

Or view, comment on, or merge it at:

#5665
Commit Summary

  • Update default.php
  • Update default_addform.php
  • Update default.php

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5665.

avatar zero-24
zero-24 - comment - 11 Jan 2015

@brianteeman i think this is out of scope of this PR :smile: This should only fix the resolution issue.

avatar brianteeman
brianteeman - comment - 11 Jan 2015

:) I suppose I asked for that. I will do a separate PR
On 11 Jan 2015 01:27, "zero-24" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman i think this is out of
scope of this PR [image: :smile:] This should only fix the resolution
issue.


Reply to this email directly or view it on GitHub
#5665 (comment).

avatar zero-24
zero-24 - comment - 11 Jan 2015

Thanks @brianteeman

avatar zero-24 zero-24 - change - 11 Jan 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 11 Jan 2015
Easy No Yes
avatar brianteeman
brianteeman - comment - 13 Jan 2015

@test all good thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5665.

avatar brianteeman brianteeman - test_item - 13 Jan 2015 - Tested successfully
avatar waader
waader - comment - 14 Jan 2015

@test success! If the scope was to hide several columns on small devices.

avatar waader waader - test_item - 14 Jan 2015 - Tested successfully
avatar zero-24 zero-24 - change - 14 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 14 Jan 2015

thanks @waader

If the scope was to hide several columns on small devices.

Yes the other issue is handeled by @brianteeman with this PR: #5679


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5665.

avatar zero-24
zero-24 - comment - 14 Jan 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5665.

avatar brianteeman brianteeman - change - 14 Jan 2015
Labels Added: ?
avatar roland-d
roland-d - comment - 17 Jan 2015

@zero-24 Can you please check your files since they can't be applied. I get the following errors:
error: patch failed: administrator/components/com_redirect/views/links/tmpl/default.php:120
error: administrator/components/com_redirect/views/links/tmpl/default.php: patch does not apply

Your branch may be out of sync.

avatar zero-24
zero-24 - comment - 17 Jan 2015

Closing: #5665 It fixes the merge conflicts Thanks @roland-d

avatar zero-24 zero-24 - close - 17 Jan 2015
avatar zero-24 zero-24 - close - 17 Jan 2015
avatar zero-24 zero-24 - change - 17 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-17 09:48:47
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment