Note to committers DO NOT merge this for 3.4. Wait until me and @phproberto have worked out the final desired form for a rendering class.

@wilsonge I am not trying to change your (and @phproberto ’s) timelines here!
My idea here was that if introducing: user, media and versions fields using layouts and bootstrap and also have #4661, #4645, #4563 and #5652 merged for 3.4 then the team could advertise that Joomla dropped almost totally Mootools in core.
BUT that could happen ONLY IF the fields DO NOT introduce a wrong approach which then will become a pain in the @$$ to try to maintain, update etc.
Also I don’t know what are the USP s for 3.4, but I assume that advertising a total transition to jQuery could be a nice feature (amongst the others)

Bottom line: if you want me to put it on hold (e.g. close it for now) I will do so

I completely understand the reasons for this! And I support killing off mootools as well. The issue for me is how we intialise and render the JLayout. The framework View package from 2.0 will likely include this renderer class Michael wrote for Jissues (see ). We had a JLayout implementation here https://github.com/joomla-projects/cms-naked/blob/master/libraries/cms/renderer/jlayout.php and were thinking about using that.

But my point is that whilst we still are really unsure about how any rendering system will work in Joomla I'm really reluctant to start doing everything before we have a 'accepted' solution. Because otherwise we start getting inconsistencies and b/c breaks. I'll try and get @phproberto to comment on this before you actually close it. But my opinion is to (reluctantly) hold it .

Thanks @wilsonge for taking care of this. I've moved all my github notifications to another folder and it's harder for me to notice things like this.

Yes. I think this should be moved to the v3.5 release. I've just had a phone call with Javier to prepare the v3.5 enviroment. I think we are going to have the same setup than v3.4 so we will have a milestone + a tag for PRs related to it. Once we have settled where & how is v3.5 code going to be managed @wilsonge and I can have the definitive renderer ready and then start telling people how integrate things like this PR.

I don't think that this PR will need a lot of changes, just use the new rendering system. I agree that it makes no sense to introduce something now to then change it on v3.5.

So I think we can keep this PR open until in around 2 weeks we have things settled. Then point it to the right place with the right instructions.

Thanks @dgt41 !!

@wilsonge @phproberto Excellent! FYI there is also a media field layout, but I forgot to push the code here, so you don’t have to redo that one as well ????. As soon as you settle the 3.5-dev repo I will bring it there!

One more think that needs your attention is #5652 which is a redo of the current implementation with a little twist to have bootstrap modal in the equation. And the question, as well there, is the same shall it wait for 3.5, or can it go in 3.4?

test works good

#Test OK

@wilsonge Have you figured things out as to what to do with this PR? Can this be merged into 3.5 or should it wait longer?

If we implement the stuff Roberto mentioned in #7948 (comment) then I'm happy (this also applies for #5655)

To test this try to edit an article in isis, hathor, protostar and beez

Expected my comment here. Hathor is broken:

and in beez we have no option to use the versions anyway (bevor and after the patch)

protostar and isis looks good to me.

@zero-24 Fixed!

@dgt41 i don't see any change (on github)? Are you sure you commit the change for $renderLayout and $layout. Did you also catch that hathor problem?

@zero-24 yes both hathor and the $layout are now fixed

Great i will try it tomorrow. Thanks.

I have tested this item unsuccessfully on f45ad43

hmm i have still the same problems with hathor here :( Sorry for the delay @dgt41

I have tested this item unsuccessfully on f45ad43

I have also issues in Hathor - it´s cut off, when the window is resized. And despite i don´t think anyone would use this on mobile - it seems to be broken also. (screens following)

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @zero-24

@designbengel Hathor and Beez are not really compatible with bootstrap. Let them use mootools…
So this PR now converts the content history modal to bootstrap ONLY for Isis and Protostar

I have tested this item successfully on 9c5bef6

Works now or lets better say it is broken the same way as bevor for hathor.

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @zero-24

I have tested this item successfully on c1596fb

Still works with hathor and isis as well as protostar. for testing this #8248 needs to be applyed as well.

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @zero-24

I have tested this item successfully on bc4331d

Works perfectly. Requires the modal CSS fixes from #5871

At squeezing the window there is some stuff cut off.

I have tested this item successfully on bc4331d

As @designbengel noted: there are cut off´s when reducing the viewport, but on the other hand they are also present in the mootools version. So being pragmatic I would suggest to go with the current version and maybe improve here and there later.

I tested with IE8 and current FF, Chrome and IE but with no mobile phone.

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @phproberto, @waader, @zero-24

Added a span with class hidden phone to make the buttons fit the mobile view. Preview:

@waader @designbengel can you confirm that is fixed now?

Great! Before retesting ... the checkbox on left side of each row is also "hidden". Maybe you have another idea to get that fixed?

This PR has received new commits.

CC: @anibalsanchez, @designbengel, @Fedik, @phproberto, @waader, @zero-24

@waader I didn’t realize that in order to compare two versions you need to be able to select them. Now should be ok

I have tested this item successfully on ba74815

now everything is nice.
Suggestion: There is a close button at the bottom. In the banner section it´s a cancel button. maybe same wording for all modals?

Now it's definitely better than the mootools version. Thanks!

Merged - two successful tests from @waader and @designbengel