Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5627] - Adding back the select box for mobile devices

? Success
Pull Request for # 5617

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
6 Jan 2015

What this PR do

Implements: #5617 (comment)

And also fix the issue No search button on moblie devices for

  • com_newsfeeds
  • com_tags
  • com_menus (menus view)
  • com_modules

I hope @brianteeman and @aasimali can review

Other issues (out of scope of this PR)

We need a UX / UI Review (what option gets hidden) for the following components but this is out of scope for this PR. (see: #5628)

  • com_redirect
  • com_messages
  • com_banners (Tracks view only)
  • com_search
  • com_finder (filters view only)
  • com_media
  • com_installer (discover, manage, update, updatesites)
  • com_languages
avatar zero-24 zero-24 - open - 6 Jan 2015
avatar jissues-bot jissues-bot - change - 6 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Jan 2015
The description was changed
avatar infograf768
infograf768 - comment - 7 Jan 2015

@test
Looks good to me

avatar zero-24 zero-24 - alter_testresult - 8 Jan 2015 - infograf768: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 8 Jan 2015 - aasimali: Tested successfully
avatar zero-24
zero-24 - comment - 8 Jan 2015

@aasimali tested this patch here: #5617 (comment)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5627.
avatar zero-24 zero-24 - change - 8 Jan 2015
Category ⇒ UI/UX
avatar zero-24 zero-24 - change - 8 Jan 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 8 Jan 2015

As we have two successful tests i moving here to RTC. Thanks to all here!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5627.
avatar zero-24 zero-24 - change - 8 Jan 2015
Rel_Number ⇒ 5617
Relation Type ⇒ Pull Request for
avatar brianteeman
brianteeman - comment - 8 Jan 2015

Removing the RTC label for reasons stated in #5643

avatar brianteeman brianteeman - change - 8 Jan 2015
Status Ready to Commit ⇒ New
avatar infograf768
infograf768 - comment - 8 Jan 2015

My test in #5643 were not made with select box on as I confirmed the issue when editing a user and saving.

avatar zero-24
zero-24 - comment - 8 Jan 2015

Removing the RTC label for reasons stated in #5643

@brianteeman This issue is unrealted to this PR and can also reproduce on the last staging. Please add RTC back here :smile:

avatar infograf768 infograf768 - change - 8 Jan 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 8 Jan 2015

adding it back indeed.

avatar zero-24 zero-24 - change - 8 Jan 2015
Status New ⇒ Ready to Commit
avatar zero-24 zero-24 - close - 8 Jan 2015
avatar infograf768 infograf768 - close - 8 Jan 2015
avatar infograf768 infograf768 - close - 8 Jan 2015
avatar infograf768 infograf768 - change - 8 Jan 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-01-08 11:06:10
avatar infograf768
infograf768 - comment - 8 Jan 2015

merged, thanks.

avatar zero-24
zero-24 - comment - 8 Jan 2015

Thanks @infograf768

avatar zero-24 zero-24 - head_ref_deleted - 8 Jan 2015
avatar brianteeman
brianteeman - comment - 8 Jan 2015

Sorry for the confusion

On 8 January 2015 at 11:08, zero-24 notifications@github.com wrote:

Thanks @infograf768 https://github.com/infograf768

—
Reply to this email directly or view it on GitHub
#5627 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment