[#5606] - module tags similar ignores expired articles - fix
- Closed
- 4 Jan 2015
- Medium
- Build: staging
- # 5606
- Diff
- brianteeman:tags
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Using mod_tags_similar, the helper returns items marked as published using core_state=1 but it also returns items which have expired as no check is made on the core_publish_up or core_publish_down columns
Tested by editing the article published state and publish up and down dates.
I am just creating the PR for the code mentioned in #4979
I did of course confirm the issue and that the PR resolves it
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Modules Tags |
| Rel_Number | ⇒ | 4979 | |
| Relation Type | ⇒ | Pull Request for |
OK - I have tried - does travis automatically run again or do i have to do
soemthing
On 4 January 2015 at 00:57, George Wilson notifications@github.com wrote:
Can you fix the code style issues brian? if not will bung you a PR tomrrow
—
Reply to this email directly or view it on GitHub
#5606 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Not sure how to fix the line length issues - can you send a PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5606.
Sure. It's not too bad. You can split these easily because of the string concatenation (brianteeman#1)
Thanks I merged your PR
On 4 Jan 2015 01:45, "George Wilson" notifications@github.com wrote:
Sure. It's not too bad. You can split these easily because of the string
concatenation (brianteeman#1
brianteeman#1)—
Reply to this email directly or view it on GitHub
#5606 (comment).
Works OK, Squashing and merging.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-04 08:47:14 |
Can you fix the code style issues brian? if not will bung you a PR tomrrow