? Success
Pull Request for # 5455

User tests: Successful: Unsuccessful:

avatar jackkum
jackkum
3 Jan 2015

#5554 and #5455

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar jackkum jackkum - open - 3 Jan 2015
avatar jissues-bot jissues-bot - change - 3 Jan 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 4 Jan 2015

@test
This works here. Will close #5554 and #5455

avatar infograf768 infograf768 - test_item - 4 Jan 2015 - Tested successfully
avatar zero-24 zero-24 - change - 4 Jan 2015
Category Tags
avatar zero-24 zero-24 - change - 4 Jan 2015
Rel_Number 5554
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 4 Jan 2015
Rel_Number 5554 5455
avatar waader
waader - comment - 5 Jan 2015

@test success!

avatar waader waader - test_item - 5 Jan 2015 - Tested successfully
avatar wilsonge
wilsonge - comment - 6 Jan 2015

This might fix the issue but is a horrific hack. This effectively nulls the entire where statement. In which case you may as well remove it all together (but not sure if that is the right answer either)

avatar jackkum
jackkum - comment - 6 Jan 2015

@wilsonge
Agree it is a crutch.
Another solution can only see in union 2 queries.

avatar jackkum
jackkum - comment - 6 Jan 2015

Why not use "where" like zf?
https://github.com/zendframework/zf1/blob/master/library/Zend/Db/Select.php#L473
All the conditions are combined by a single operator (and, or) it is not convenient.

avatar wilsonge
wilsonge - comment - 7 Jan 2015
avatar jackkum
jackkum - comment - 7 Jan 2015

it is apply for all where conditions.

$query = $db->getQuery(true);
$query->select('*');
$query->from('...');
$query->where('cond', 'OR');
$query->where('cond1', 'AND');
$query->where('cond2');
// result will be select * from ... where cond OR cond1 OR cond2
avatar jackkum
jackkum - comment - 7 Jan 2015

on zf this will be

$query = $db->select();
$qurey->from('...');
$query->where('cond');
$query->orWhere('cond1');
$query->where('cond2');
// result will be select * from ... where (cond) OR (cond1) AND (cond2)
avatar gunjanpatel
gunjanpatel - comment - 26 Jan 2015

Agree with @jackkum here. We have second argument but it applies to all where. So, if we want to write query with AND and OR condition together it's somehow not possible in current where function.
We need orwhere or andwhere functions. But not agree with this changes. This should be improve in other way. :)

avatar gunjanpatel gunjanpatel - change - 26 Jan 2015
Status Pending Needs Review
avatar Joomti
Joomti - comment - 14 Mar 2015

For me it works as it should.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5601.
avatar Joomti Joomti - test_item - 14 Mar 2015 - Tested successfully
avatar wilsonge
wilsonge - comment - 14 Mar 2015

I'm closing this as it's completely the wrong fix as I described. We need to rewrite this query properly rather than adding this statement

avatar wilsonge wilsonge - change - 14 Mar 2015
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 15:02:26
avatar wilsonge wilsonge - close - 14 Mar 2015
avatar wilsonge wilsonge - close - 14 Mar 2015
avatar vdespa
vdespa - comment - 14 Mar 2015

I am not very familiar with the internals of com_tags, but this seems rather like a limitation and not a bug. You can later add tags if you write 3 letters from the tag it will be displayed.

If this PR is not updated in the next 30 days, it would be closed, as it cannot be merged in the current state.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5601.
avatar vdespa vdespa - test_item - 14 Mar 2015 - Tested unsuccessfully
avatar wilsonge
wilsonge - comment - 14 Mar 2015

@vdespa i think you are commenting on the wrong issue ^.^

avatar jackkum jackkum - head_ref_deleted - 20 Mar 2015

Add a Comment

Login with GitHub to post a comment