User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Category | ⇒ | Tags |
Rel_Number | ⇒ | 5554 | |
Relation Type | ⇒ | Pull Request for |
Rel_Number | 5554 | ⇒ | 5455 |
This might fix the issue but is a horrific hack. This effectively nulls the entire where statement. In which case you may as well remove it all together (but not sure if that is the right answer either)
Why not use "where" like zf?
https://github.com/zendframework/zf1/blob/master/library/Zend/Db/Select.php#L473
All the conditions are combined by a single operator (and, or) it is not convenient.
We do have a second parameter for where (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/query.php#L1492)
it is apply for all where conditions.
$query = $db->getQuery(true);
$query->select('*');
$query->from('...');
$query->where('cond', 'OR');
$query->where('cond1', 'AND');
$query->where('cond2');
// result will be select * from ... where cond OR cond1 OR cond2
on zf this will be
$query = $db->select();
$qurey->from('...');
$query->where('cond');
$query->orWhere('cond1');
$query->where('cond2');
// result will be select * from ... where (cond) OR (cond1) AND (cond2)
Agree with @jackkum here. We have second argument but it applies to all where. So, if we want to write query with AND
and OR
condition together it's somehow not possible in current where
function.
We need orwhere
or andwhere
functions. But not agree with this changes. This should be improve in other way. :)
Status | Pending | ⇒ | Needs Review |
For me it works as it should.
I'm closing this as it's completely the wrong fix as I described. We need to rewrite this query properly rather than adding this statement
Status | Needs Review | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-14 15:02:26 |
I am not very familiar with the internals of com_tags, but this seems rather like a limitation and not a bug. You can later add tags if you write 3 letters from the tag it will be displayed.
If this PR is not updated in the next 30 days, it would be closed, as it cannot be merged in the current state.
@test
This works here. Will close #5554 and #5455