[#5589] - [fix] Admin modules: Switch hardcoded date to JText string
- Closed
- 2 Jan 2015
- Medium
- Build: staging
- # 5589
- Diff
- infograf768:hardcodeddateadminmodules
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
mod_latest, mod_popular and mod_logged are using hardcoded date format.
See http://forum.joomla.org/viewtopic.php?f=711&t=854857#p3254178
This prevents custom format by specific language strings or overrides.
This PR changes 'Y-m-d' to JText::_('DATE_FORMAT_LC4')
For example here, the string is overriden from
DATE_FORMAT_LC4="Y-m-d"
to
DATE_FORMAT_LC4="d/m/y"
jissues-bot
- | Labels |
Added:
?
|
||
@810 did you any kind of testing or you simple agree with this pull request?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5589.
Thanks for doing this - I put this on tthe feature tracker 18 months ago
but forgot about it
I would prefer the default to be d-m-y which is the en-GB standard format
for dates but we dont have that defined in the ini
On 2 January 2015 at 09:36, Peter Martin notifications@github.com wrote:
@test https://github.com/test
Patch works fine!Extensions > Language Manager > Overrides > Filter [English (United
Kingdom - Administrator] > New
Language Constant * - DATE_FORMAT_LC4
Text: d.m.Y[image: joomla test - administration - control panel]
https://cloud.githubusercontent.com/assets/1217850/5595142/2d8e633e-926b-11e4-948a-5b3386a4dfc4.png—
Reply to this email directly or view it on GitHub
#5589 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Category | ⇒ | Administration UI/UX |
Thanks @810 http://issues.joomla.org/tracker/joomla-cms/5589#event-56757
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5589.
| Status | Pending | ⇒ | Ready to Commit |
Moving to RTC Thanks @infograf768 @810 and @pe7er
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5589.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-02 10:41:42 |
@810
Of you consider that the nl-NL language needs changes, please contact the coordinator:
(date formats strings are present in front and back-end)
http://community.joomla.org/translations/joomla-3-translations.html#nl-nl
+1