? Success

User tests: Successful: Unsuccessful:

avatar smz
smz
2 Jan 2015

This is the same as #5569, but with the modified JPath::clean() and no JPath::ux_clean()

avatar smz smz - open - 2 Jan 2015
avatar jissues-bot jissues-bot - change - 2 Jan 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 2 Jan 2015

So is this a replacement for #5569 ?? Of so please close that PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5586.

avatar smz
smz - comment - 2 Jan 2015

@brianteeman No, it is not a replacement: it is an alternative...

avatar brianteeman
brianteeman - comment - 2 Jan 2015

You are modifying external libraries such as FoF - please dont. they are
maintained seperatley

On 2 January 2015 at 01:50, Sergio Manzi notifications@github.com wrote:

@brianteeman https://github.com/brianteeman No, it is not a
replacement: it is an alternative...


Reply to this email directly or view it on GitHub
#5586 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Hutchy68 Hutchy68 - close - 2 Jan 2015
avatar Hutchy68
Hutchy68 - comment - 2 Jan 2015

Since you are modifying external libraries, it is a no brainer. Closing!

Please do not create multiple PRs for the same issue. It makes it much harder to follow the conversion. Reminding you, many developers have already given you advice, start small. You are only wasting your time and theirs. Thanks!

avatar Hutchy68 Hutchy68 - close - 2 Jan 2015
avatar Hutchy68 Hutchy68 - change - 2 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-02 02:33:50
avatar smz
smz - comment - 2 Jan 2015

@brianteeman & @Hutchy68 Sorry, but I was under the impression that FoF is not an external library anymore (the external one being F0F)... Am I wrong?

avatar smz
smz - comment - 2 Jan 2015

@mbabker Thanks for all the suggestions/advices. Most of them have been incorporated in a commit to #5569.

For the reasons you very well know this PR is a dead horse, so if in the future you'll have more advices for me, please use #5569

In it, at least for the moment, I'm not going to change the calls to JPath::ux_clean() to JPath::clean(..., '/') as this will probably be really wasted time. I will do in the unlikely event that the PR is for unforeseeable reasons accepted.

Your help is really appreciated: you're a master and a gentleman.

avatar wilsonge
wilsonge - comment - 2 Jan 2015

FOF is 3rd party and is maintained at www.github.com/akeeba/fof

avatar smz
smz - comment - 2 Jan 2015

@wilsonge My bad: I thought that after the controversy about the change in licensing terms @nikosdion had "donated" FOF to the Joomla project and abandoned its development (F0F being his new incarnation used in his products).

avatar smz smz - head_ref_deleted - 23 Aug 2015
avatar smz smz - head_ref_restored - 23 Aug 2015
avatar smz smz - head_ref_deleted - 23 Aug 2015
avatar smz smz - head_ref_restored - 23 Aug 2015
avatar smz smz - head_ref_deleted - 23 Aug 2015
avatar smz smz - head_ref_restored - 23 Aug 2015

Add a Comment

Login with GitHub to post a comment