Feeling Lucky
?
[#5566] - Fixes favicon issues in Windows (#5559)
- Closed
- 29 May 2015
- Medium
- Build: staging
- # 5566
- Diff
- smz:FixesWindowsFavicon
- Success The Travis CI build passed Details
Pull Request for
# 5559
User tests: Successful: Unsuccessful:
jissues-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
| Rel_Number | ⇒ | 5559 | |
| Relation Type | ⇒ | Pull Request for |
richard67
- comment
- 4 Feb 2015
And now we also have #5967 , which I've just tested with success. I think there where #5967 corrects code, the usage of DIRECTORY_SEPARATOR makes sense.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5566.
richard67
- comment
- 4 Feb 2015
P.S.: Please @smz check if this one here can be closed in favour of #5967 .
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5566.
smz
- comment
- 5 Feb 2015
Sorry, Richard, I'm not contributing to this project any more: I've totally lost my trust in it and the way it is managed.
Regards,
Sergio
brianteeman
- comment
- 5 Feb 2015
Thank you for your kind words
Bakual
- comment
- 5 Feb 2015
I edited the offending things out of the comments. This is certainly not the place for personal attacks. Thanks for keeping that in memory.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-29 01:53:32 |
| Closed_By | ⇒ | smz |
I'm leaving this open as it actually solves an issue with current code, but I strongly believe the correct solution is to to standardize on
/as the directory separator and forget about DIRECTORY_SEPARATOR once and forever.For discussion please use #5559