? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
29 Dec 2014

In addition to updating the CodeMirror Javascript and css files, this update exposes a new CodeMirror option via the plugin's configuration screen in the Joomla! administrator. It's a minor thing, you can now select a scrollbar style.

Oh, and CodeMirror 4.9 also includes 2 new dark themes so maybe one of them appeals to someone.

avatar okonomiyaki3000 okonomiyaki3000 - open - 29 Dec 2014
avatar jissues-bot jissues-bot - change - 29 Dec 2014
Labels Added: ?
avatar brianteeman
brianteeman - comment - 29 Dec 2014

New language strings are good

avatar zero-24
zero-24 - comment - 29 Dec 2014

@okonomiyaki3000 one smal CS issue:

FILE: ...ravis/build/joomla/joomla-cms/plugins/editors/codemirror/codemirror.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 300 | ERROR | Concat operator must be preceeded by one space
--------------------------------------------------------------------------------

I will have a look if i get some time for it

avatar brianteeman brianteeman - change - 29 Dec 2014
Category External Library
avatar okonomiyaki3000
okonomiyaki3000 - comment - 30 Dec 2014

Shoot, SublimeText was showing me a warning about that too but somehow I missed it.

avatar smz
smz - comment - 30 Dec 2014

Unable to test with com_patchtester:

Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 1532550 bytes) in D:\UniServerZ\vhosts\smztest\libraries\joomla\database\driver.php on line 1636

Any other way to test this? Should we just merge it, test, and revert in case of issues?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 30 Dec 2014

There is no way that this patch should cause you to run out of memory while trying to replace your database table prefix. Maybe you have some extension trying to run a huge query? It has nothing to do with this patch. Also, I don't know what com_patchtester is. Maybe that's the problem.

avatar smz
smz - comment - 30 Dec 2014

Also, I don't know what com_patchtester is. Maybe that's the problem.

I guess so... :smile:

com_patchtester is a (very nice!) component that allows you apply patches on the fly (from the available PRs), test them and then when you've finished testing revert the patch. This is a tool I constantly use to test PRs...

See: https://github.com/joomla-extensions/patchtester

The problem (I think) is that this PR is too "big" for com_patchtester (or my PHP max memory)...

avatar okonomiyaki3000
okonomiyaki3000 - comment - 30 Dec 2014

CodeMirror touches a lot of files, that can't be helped.

avatar smz
smz - comment - 30 Dec 2014

Yes, I've seen... I think we should just wait for a decision from the maintainers to merge this without the two normally required successful tests...

Thanks for the mod, anyway: IMHO codemirror is second best editor for Joomla after... editor:none! :stuck_out_tongue_winking_eye:

avatar smz
smz - comment - 30 Dec 2014

<ot>I think I should try "Sublime editor" for code editing: I heard a lot of nice things about it. Currently I'm using Notepad++<ot>

avatar okonomiyaki3000
okonomiyaki3000 - comment - 30 Dec 2014

Yes, it's very good. If you like Notepad++, you'll probably only like SublimeText more.

avatar smz
smz - comment - 30 Dec 2014

thanks! :+1:

avatar infograf768
infograf768 - comment - 30 Dec 2014

Works fine here. Thanks!. Merging.

avatar infograf768 infograf768 - close - 30 Dec 2014
avatar infograf768 infograf768 - change - 30 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-30 08:02:31

Add a Comment

Login with GitHub to post a comment