User tests: Successful: Unsuccessful:
In addition to updating the CodeMirror Javascript and css files, this update exposes a new CodeMirror option via the plugin's configuration screen in the Joomla! administrator. It's a minor thing, you can now select a scrollbar style.
Oh, and CodeMirror 4.9 also includes 2 new dark themes so maybe one of them appeals to someone.
Labels |
Added:
?
|
@okonomiyaki3000 one smal CS issue:
FILE: ...ravis/build/joomla/joomla-cms/plugins/editors/codemirror/codemirror.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
300 | ERROR | Concat operator must be preceeded by one space
--------------------------------------------------------------------------------
I will have a look if i get some time for it
Category | ⇒ | External Library |
Shoot, SublimeText was showing me a warning about that too but somehow I missed it.
Unable to test with com_patchtester:
Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to allocate 1532550 bytes) in D:\UniServerZ\vhosts\smztest\libraries\joomla\database\driver.php on line 1636
Any other way to test this? Should we just merge it, test, and revert in case of issues?
There is no way that this patch should cause you to run out of memory while trying to replace your database table prefix. Maybe you have some extension trying to run a huge query? It has nothing to do with this patch. Also, I don't know what com_patchtester is. Maybe that's the problem.
Also, I don't know what com_patchtester is. Maybe that's the problem.
I guess so...
com_patchtester is a (very nice!) component that allows you apply patches on the fly (from the available PRs), test them and then when you've finished testing revert the patch. This is a tool I constantly use to test PRs...
See: https://github.com/joomla-extensions/patchtester
The problem (I think) is that this PR is too "big" for com_patchtester (or my PHP max memory)...
CodeMirror touches a lot of files, that can't be helped.
Yes, I've seen... I think we should just wait for a decision from the maintainers to merge this without the two normally required successful tests...
Thanks for the mod, anyway: IMHO codemirror is second best editor for Joomla after... editor:none!
<ot>I think I should try "Sublime editor" for code editing: I heard a lot of nice things about it. Currently I'm using Notepad++<ot>
Yes, it's very good. If you like Notepad++, you'll probably only like SublimeText more.
thanks!
Works fine here. Thanks!. Merging.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-30 08:02:31 |
New language strings are good