[#5523] - clean up language filter: remove unneeded "if (!$this->default_lang)" line 66
- Closed
- 27 Dec 2014
- Medium
- Build: staging
- # 5523
- Diff
- HermanPeeren:PR-language-filter
User tests: Successful: Unsuccessful:
Checking if the default_lang property is filled, was a reminiscense of those properties being static and the constructor only being called once. The comment 2 lines higher ("Ensure that constructor is called one time") belonged to this conditional. Now the properties are not static anymore and so the test is not necessary, as the constructor is only called once for every instantiation.
To TEST this PR: multilanguage should be working exactly the same when applied, for no functionality is changed. Just removed a test that would always evaluate to true.
Comment: there is some deprecated code used:
- JApplication::getHash should now be JApplicationHelper::getHash
- JString should now be \Joomla\String\String
Maybe we shoud clean that up too in one go.
jissues-bot
- | Labels |
Added:
?
|
||
Do it in separate PR's. I did one for the JApplication::getHash last night. The strong one should be done globally as well like we did Registry.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-27 13:34:19 |
@test success
Good catch!
As far as regards a further clean-up I personally would say: "Why not? If you're willing, go for it!"