With current staging saving whatever "item" (Articles, Categories, Menu items, Modules, ... whatever) I'm getting an error message which is of class alert alert-error
in most cases, but just alert
in Menu Manger. "Items" are anyway saved, so it seems an issue with the error messages. In Category Manager after the apparently botched save, the category title is also cleared.
The regression occurred sometime between commits 9e1a05b (working) and 8823d87 (not working).
See examples here below:
Can you correct that? Need a PR?
... and doesn't maybe this disclose a small issue in Menu Manager? Why alert
only in it?
I can confirm the problem.
So if load returns false every time is this a symptom of a bigger problem? or what?
I really don't know: what I see is that load()
returning false for those conditions breaks the saving of every possible "item", from modules, to articles, through menu items... everything.
IMHO, I'll revert to the previous code (to have Joomla! working), then I'll analyze the nature of the problem: if it is indeed correct load() returning false for those conditions, that would mean that it is somehow "misused" somewhere or in many places.
... and I would be scared like hell that the same can happens to some or many other 3rd party extensions
I've reverted this. But could you please (as and when you have time over xmas) have a look into this? Because me and Roland had a (super) long chat over this and felt it shouldn't be returning true and I'd love to know what the hell is going wrong :P
OK, no problem: for what I'm able, I'll surely give a look and let you know!
Thanks, an merry Xmas!
Closing as revert is effective.
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-25 08:29:41 |
Labels |
Added:
?
|
Well, let's look at the diff... 9e1a05b...8823d87
If I had to take an untested wild guess, I'd start with 9fc3055 as that's the only patch in the diff that is high enough in the system to cause errors across multiple components in the save routine.