[#5511] - Change "Remove" button to "Unfeature" in featured articles admin view - see PR #5485
- Closed
- 25 Dec 2014
- Medium
- Build: staging
- # 5511
- Diff
- richard67:patch-2
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary
With this PR, the button "Remove" in the featured articles view of the article manager is changed to a button "Unfeature" as discussed with PR #5485 .
The function of the button stays the same, but text and icon will be less misleading.
Dependencies
For the Hathor template, the changes in CSS from PR #5485 are required to see the correct icon for the button.
Testing
Check label, icon and function of the button right beside the "Unpublish" button on the featured articles view of the article manager.
Before applying patch with this PR
Label = "Remove", icon is an "X" in isis template, with thie button selected featured articles will be changed so they are not featured anymore and so disappear from this list (but still are there, check in article manager's articles view)
After applying patch
Label = "Unfeature", icon is the same as used in the articles list for unfeatured status of articles (unfilled star in isis template), functions is unchanged
jissues-bot
- | Labels |
Added:
?
|
||
Added hint to test description that described icons are those of the isis template.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5511.
@N6REJ Thanks for testing. Could you submit the test result with the form on the right hand side of the issue tracker, too? Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5511.
En-gb you are changing from an action word to a description word. That is
not correct English.
On 24 Dec 2014 14:51, "Richard Fath" notifications@github.com wrote:
@N6REJ https://github.com/N6REJ Thanks for testing. Could you submit
the test result with the form on the right hand side of the issue tracker,too? Thanks in advance.
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/5511
http://issues.joomla.org/tracker/joomla-cms/5511.—
Reply to this email directly or view it on GitHub
#5511 (comment).
@brianteeman Yes, I know, but as described above I did it in order to be consistent with PR #5485, assuming that changes will be done with that PR, as discussed there.
So where shall we handle these language-related discussions now?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5511.
| Title |
|
||||||
| Title |
|
||||||
Changed description of this PR to reflect change from "Unfeatured" to "Unfeature" as required by @brianteeman .
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5511.
@brianteeman Done.
@all Please somebody re-test. And merry x-mas for all 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5511.
OK here. @brianteeman ?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-25 11:02:19 |
| Milestone |
Added: |
||
@test works as desired.