? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
23 Dec 2014
  • When looping by reference, reference variable is not unset at the end of the loop.
  • and a bit CodeStyle

see: #5482

avatar zero-24 zero-24 - open - 23 Dec 2014
avatar jissues-bot jissues-bot - change - 23 Dec 2014
Labels Added: ?
avatar zero-24 zero-24 - change - 23 Dec 2014
Category Code style
avatar waader
waader - comment - 27 Jan 2015

@zero-24 Is this something to test or does it need review by PLT?

avatar zero-24
zero-24 - comment - 27 Jan 2015

Thanks @waader no we can't test this. And it is no bug it is more a bad practice.

@ggppdk (at: #5482 (comment)):

Again this is not a bug, just a very dangerous practice not to unset the variable that references the array of the loop.

or does it need review by PLT?

Yes it needs only a decision / review by the PLT to remove this bad practice or not. So nothing to test here. Thanks! :smile:

avatar zero-24 zero-24 - close - 19 Mar 2015
avatar zero-24 zero-24 - close - 19 Mar 2015
avatar zero-24 zero-24 - change - 19 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-19 21:57:17
Closed_By zero-24
avatar zero-24
zero-24 - comment - 19 Mar 2015

Closing since we have no response since 23 Dec 2014


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5495.

avatar zero-24 zero-24 - change - 19 Mar 2015
Closed_Date 2015-03-19 21:57:17 2015-03-19 21:57:18
avatar zero-24 zero-24 - head_ref_deleted - 19 Mar 2015

Add a Comment

Login with GitHub to post a comment