? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
20 Dec 2014

This PR unify the example emails to example.org for the sample data.

Example domains
As described in RFC 2606 and RFC 6761, a number of domains such as example.com and example.org for documentation purposes. These domains may be used as illustrative examples in documents without prior coordination with us. They are not available for registration or transfer.

http://www.iana.org/domains/reserved

avatar zero-24 zero-24 - open - 20 Dec 2014
avatar jissues-bot jissues-bot - change - 20 Dec 2014
Labels Added: ?
avatar brianteeman
brianteeman - comment - 21 Dec 2014

I am all for consistency but why change them all from example.com to
example.org

I didnt see anything other than example.com in current use and that is a
valid domain to use according to the RFC

On 20 December 2014 at 23:58, zero-24 notifications@github.com wrote:

This PR unify the example emails to example.org for the sample data.

Example domains
As described in RFC 2606 and RFC 6761, a number of domains such as example.com and example.org for documentation purposes. These domains may be used as illustrative examples in documents without prior coordination with us. They are not available for registration or transfer.

http://www.iana.org/domains/reserved

You can merge this Pull Request by running

git pull https://github.com/zero-24/joomla-cms patch-18

Or view, comment on, or merge it at:

#5484
Commit Summary

  • Update sample_brochure.sql
  • Update sample_learn.sql
  • Update sample_learn.sql
  • Update sample_testing.sql
  • Update sample_learn.sql
  • Update sample_testing.sql
  • Update sample_brochure.sql
  • Update sample_learn.sql
  • Update sample_testing.sql

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5484.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 21 Dec 2014

moved example.org to example.com @brianteeman

avatar brianteeman
brianteeman - comment - 21 Dec 2014

My mistake - oops - sorry. I didnt see that you were changing some from
email.com to example

Great that they are all now consistent

On 21 December 2014 at 11:00, zero-24 notifications@github.com wrote:

moved example.org to example.com @brianteeman
https://github.com/brianteeman


Reply to this email directly or view it on GitHub
#5484 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 21 Dec 2014

All good - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5484.
avatar brianteeman brianteeman - test_item - 21 Dec 2014 - Tested successfully
avatar brianteeman brianteeman - change - 22 Dec 2014
Category Installation MS SQL Postgresql SQL
avatar wilsonge
wilsonge - comment - 27 Dec 2014

This was merged with b4b5702

avatar wilsonge wilsonge - close - 27 Dec 2014
avatar wilsonge wilsonge - change - 27 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-27 18:07:28
avatar sovainfo
sovainfo - comment - 27 Dec 2014

Suggest to fix the errors on line 193,194 of postgresql/sample_learn.sql: too many \' !

avatar wilsonge
wilsonge - comment - 27 Dec 2014

If you give a PR I'll merge it asap :)

avatar zero-24
zero-24 - comment - 27 Dec 2014

This was merged with b4b5702

:+1: @wilsonge

Add a Comment

Login with GitHub to post a comment