?

User tests: Successful: Unsuccessful:

avatar J0WI
J0WI
20 Dec 2014

Based on #5415 (comment)
I excluded extension.joomla.org, because it does support https on all paths.

avatar J0WI J0WI - open - 20 Dec 2014
avatar jissues-bot jissues-bot - change - 20 Dec 2014
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 Dec 2014

Global search and replaces are BAD, BAD, BAD

The first language string change I checked made no sense to change

On 20 December 2014 at 18:35, J0WI notifications@github.com wrote:

Based on #5415 (comment)
#5415 (comment)
I excluded extension.joomla.org, because it does support https on all

paths.

You can merge this Pull Request by running

git pull https://github.com/J0WI/joomla-cms https-links

Or view, comment on, or merge it at:

#5478
Commit Summary

  • https on php and sql files
  • https for all found domains
  • https for all found domains
  • https for all found domains
  • https for all found domains

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5478.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar J0WI
J0WI - comment - 20 Dec 2014

What's the reason to not change this string? It won't break anything.

avatar J0WI
J0WI - comment - 20 Dec 2014

I hope this change will force the joomla.org content team to update hardcoded http links and finally move the whole site to https only. IMHO it's not our failure if a site has mixed content issues.

This change referrers to the HTTPS-Everywhere project:
https://github.com/EFForg/https-everywhere/blob/master/src/chrome/content/rules/Joomla.xml
https://github.com/EFForg/https-everywhere/blob/master/src/chrome/content/rules/JoomlaCode.org.xml

avatar mbabker
mbabker - comment - 20 Dec 2014

The sites themselves are in the process of being updated. I'm not in favor of just batch updating the links for the sake of doing so and in some cases causing sites to appear broken. Even "simpler" sites like our API subdomain took several hours of review before being converted to HTTPS only; the large domains like www and community may take several days of someone reviewing full time for full compatibility.

From what I can tell, references to docs (which is already forcing HTTPS) and the help.joomla.org/proxy installation can be safely updated now. Other installations should not be updated until they have been fully reviewed and certified to work correctly.

avatar Hutchy68
Hutchy68 - comment - 20 Dec 2014

Right now, the only two sites I know which are fully https are api.joomla.org through rewrite and docs.joomla.org. Actually docs isn't reachable by http at all, port 80 is completely unavailable and all incoming to http are forwarded to https with a 301.

I would be in favor of closing this and starting over. Only include sites known to be working.

help.j and help.j.org/proxy are 2 completely different installs. I have no access or knowledge as to their status.

avatar mbabker
mbabker - comment - 20 Dec 2014

help.joomla.org/proxy itself seems to be fine for what content it's serving to the CMS (I've done some checks).

The main help site seems fine, a couple mixed content messages on images from the shop which don't exist though.

avatar Bakual
Bakual - comment - 21 Dec 2014

Closing this as we need to change the links on a per site base.
Also I wonder if it makes sense to have https links to sites which are basically readonly for most visitors. Imho there is not much point in forcing https for sites like joomla.org where people never transmit any sensitive data.

avatar zero-24 zero-24 - change - 22 Dec 2014
Status Pending Closed
avatar jissues-bot
jissues-bot - comment - 22 Dec 2014

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/5478

avatar jissues-bot jissues-bot - close - 22 Dec 2014
avatar jissues-bot jissues-bot - close - 22 Dec 2014
avatar zero-24
zero-24 - comment - 22 Dec 2014

Closing this as we need to change the links on a per site base.

Realy closing now :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5478.

avatar jissues-bot jissues-bot - change - 22 Dec 2014
Closed_Date 0000-00-00 00:00:00 2014-12-22 18:31:30
avatar J0WI
J0WI - comment - 13 Jan 2015

@Bakual @mbabker @zero-24 Shall I make a new pull request just for the domains that are confirmed to be working fine?
I really want this for the next release. I could tell you a bunch of reason why we should enforce https everywhere.

avatar mbabker
mbabker - comment - 13 Jan 2015

We are working on it. In terms of what is linked from the CMS, I think we have captured everything at the moment that is ready.

joomla.org sites linked by the CMS repo:

  • www.joomla.org - Mixed Content Issues (note that this issue does not apply to the RSS feeds, which can safely be updated (see #5712)
  • issues.joomla.org - Unsupported (server does not have SSL cert installed)
  • developer.joomla.org - Unsupported (server does not have SSL cert installed)
  • build.joomla.org - Unsupported (server does not have SSL cert installed)
  • docs.joomla.org - Links updated, site forces HTTPS
  • demo.joomla.org - Site itself forces SSL, links can be updated
  • community.joomla.org - Mixed Content Issues
  • extensions.joomla.org - Unsupported (redirected to HTTP)
  • forum.joomla.org - Several issues (cert identity mismatch, submitting to HTTP from HTTPS, mixed content)
  • resources.joomla.org - Mixed Content Issues (causes the front page to appear broken)
  • update.joomla.org - Unsupported (redirects to CDN provider)
  • help.joomla.org - The links for the help proxy sub-directory have been updated and it is forcing HTTPS, the main site is in Joomla's offline mode

Just blanket changing all the links IMO is not an option. It looks just as bad on the project to serve links to known broken pages as not having fully enabled HTTPS sites. As I've said, it is a work in progress (sites are getting updated and forcing HTTPS connections as appropriate), but it's something that takes time with a domain as large as Joomla's.

avatar J0WI J0WI - head_ref_deleted - 18 Jul 2015

Add a Comment

Login with GitHub to post a comment