? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
18 Dec 2014

...ons

I have changed the default "Allow User Registration" setting from ON to OFF as discussed in this topic: https://groups.google.com/forum/#!topic/joomla-dev-cms/I5QR5pLaIIA

I also added the change in these two test files:
/joomla-cms/tests/unit/stubs/database/jos_extensions.csv
/joomla-cms/tests/unit/suites/libraries/joomla/utilities/stubs/test.xml

The setting should not be applied to existing websites and therefore I did not create any SQL update files.

avatar pe7er pe7er - open - 18 Dec 2014
avatar jissues-bot jissues-bot - change - 18 Dec 2014
Labels Added: ?
avatar pe7er
pe7er - comment - 18 Dec 2014

Test instruction:
1. Download the latest Joomla 3.4
2. Apply this patch before installing Joomla
3. In back-end > Users > User Manager, click [options]
on the 1st tab ("Components") the option "Allow User Registration" should be "No".

joomla 3 4dev - administration - users configuration

Applying the patch on an existing Joomla 3.4 website should not change the state of "Allow User Registration"

avatar brianteeman brianteeman - change - 18 Dec 2014
Category Installation MS SQL Postgresql SQL
avatar Bakual
Bakual - comment - 18 Dec 2014

Codereview is fine and I agree with this change. Thanks for coding!

avatar peterlose
peterlose - comment - 18 Dec 2014

Great! Now this can be wiped from the todo list when launching new sites :)

avatar smz
smz - comment - 19 Dec 2014

Totally agree with this change. Thanks @pe7er
@test success (based on code review)

avatar smz smz - test_item - 19 Dec 2014 - Tested successfully
avatar pe7er
pe7er - comment - 19 Dec 2014

If this PR is added to the Joomla 3.4 core, we might have to change the documentation on the following pages:

https://docs.joomla.org/Allowing_user_registration
"enable user registration (this is the default)"
to
"enable user registration (this was the default. Since Joomla 3.4 it is disabled by default)"

https://docs.joomla.org/Setting_user_registration_policy
"By default casual visitors are allowed to register themselves on your website to gain access to additional resources."
to
"Up to Joomla 3.4 casual visitors were by default allowed to register themselves on your website to gain access to additional resources."
and
"enable user registration (this is the default)."
to
"enable user registration (this was the default. Since Joomla 3.4 it is disabled by default)"

https://docs.joomla.org/Help33:Components_Users_Configuration
"Allow User Registration. Yes or No. If set Yes, users can register from the front end of the site using the Create an Account link provided on the Login module. If set to No, the "Create and Account" link will not show."
to
"Allow User Registration. Yes or No. If set Yes, users can register from the front end of the site using the Create an Account link provided on the Login module. If set to No, the "Create and Account" link will not show. Since Joomla 3.4 this option is set to No by default"

avatar infograf768 infograf768 - change - 19 Dec 2014
Milestone Added:
avatar infograf768
infograf768 - comment - 19 Dec 2014

Travis is happy, all are happy, What else? :)
Merging.

avatar infograf768 infograf768 - reference | 3314d10 - 19 Dec 14
avatar infograf768 infograf768 - merge - 19 Dec 2014
avatar infograf768 infograf768 - close - 19 Dec 2014
avatar infograf768 infograf768 - close - 19 Dec 2014
avatar infograf768 infograf768 - change - 19 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-19 09:15:18
avatar brianteeman
brianteeman - comment - 19 Dec 2014

@pe7er can you update the docs site now please ;)

On 19 December 2014 at 09:15, infograf768 notifications@github.com wrote:

Merged #5468 #5468.


Reply to this email directly or view it on GitHub
#5468 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar pe7er
pe7er - comment - 19 Dec 2014

Thanks!
I have updated the docs site...

avatar brianteeman
brianteeman - comment - 19 Dec 2014

AWESOME!!!!

On 19 December 2014 at 09:55, Peter Martin notifications@github.com wrote:

Thanks!
I have updated the docs site...


Reply to this email directly or view it on GitHub
#5468 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment