User tests: Successful: Unsuccessful:
...ons
I have changed the default "Allow User Registration" setting from ON to OFF as discussed in this topic: https://groups.google.com/forum/#!topic/joomla-dev-cms/I5QR5pLaIIA
I also added the change in these two test files:
/joomla-cms/tests/unit/stubs/database/jos_extensions.csv
/joomla-cms/tests/unit/suites/libraries/joomla/utilities/stubs/test.xml
The setting should not be applied to existing websites and therefore I did not create any SQL update files.
Labels |
Added:
?
|
Category | ⇒ | Installation MS SQL Postgresql SQL |
Codereview is fine and I agree with this change. Thanks for coding!
Great! Now this can be wiped from the todo list when launching new sites :)
If this PR is added to the Joomla 3.4 core, we might have to change the documentation on the following pages:
https://docs.joomla.org/Allowing_user_registration
"enable user registration (this is the default)"
to
"enable user registration (this was the default. Since Joomla 3.4 it is disabled by default)"
https://docs.joomla.org/Setting_user_registration_policy
"By default casual visitors are allowed to register themselves on your website to gain access to additional resources."
to
"Up to Joomla 3.4 casual visitors were by default allowed to register themselves on your website to gain access to additional resources."
and
"enable user registration (this is the default)."
to
"enable user registration (this was the default. Since Joomla 3.4 it is disabled by default)"
https://docs.joomla.org/Help33:Components_Users_Configuration
"Allow User Registration. Yes or No. If set Yes, users can register from the front end of the site using the Create an Account link provided on the Login module. If set to No, the "Create and Account" link will not show."
to
"Allow User Registration. Yes or No. If set Yes, users can register from the front end of the site using the Create an Account link provided on the Login module. If set to No, the "Create and Account" link will not show. Since Joomla 3.4 this option is set to No by default"
Milestone |
Added: |
Travis is happy, all are happy, What else? :)
Merging.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-19 09:15:18 |
@pe7er can you update the docs site now please ;)
On 19 December 2014 at 09:15, infograf768 notifications@github.com wrote:
—
Reply to this email directly or view it on GitHub
#5468 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Thanks!
I have updated the docs site...
AWESOME!!!!
On 19 December 2014 at 09:55, Peter Martin notifications@github.com wrote:
Thanks!
I have updated the docs site...—
Reply to this email directly or view it on GitHub
#5468 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Test instruction:
1. Download the latest Joomla 3.4
2. Apply this patch before installing Joomla
3. In back-end > Users > User Manager, click [options]
on the 1st tab ("Components") the option "Allow User Registration" should be "No".
Applying the patch on an existing Joomla 3.4 website should not change the state of "Allow User Registration"