[#5458] - Load menus before triggering before and after delete events
- Closed
- 10 Feb 2015
- Medium
- Build: staging
- Easy Test
- # 5458
- Diff
- amazeika:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Problem
Menu objects aren't being loaded before triggering before and after delete events.
Consequences
With #4308 changes, we are now triggering events on Menu delete actions. If the object isn't loaded before triggering these events, the data being passed to the handlers is incomplete.
Test instructions
- Download The Joomla Catcher package. This package may be found at https://github.com/nooku/joomla-catcher. Just download the whole repo as a zip. This zip is installable AS IS.
- Install the package that you've just downloaded.
- Enable the Events Catcher - Content plugin and make sure that the onContentBeforeDelete and onContentAfterDelete are selected in the plugin configuration. Also make sure that the "Show data" option is enabled.
- Create a new menu (not a menu item, a menu).
- Delete the menu.
At this point the catcher plugin will raise a message for each event that got triggered. Without the patch, the menu data that gets passed to the event handler is missing (only ID is available in the after delete event). With the patch included in this PR, all the menu data is made available to the handlers, i.e. id, menutype, title and description.
Thank you in advance for considering this PR.
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Components |
| Easy | No | ⇒ | Yes |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-10 21:03:58 |
@test successful Thanks for the patch @amazeika
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5458.