[#5453] - Use HTML 5 input attributes when possible
- Closed
- 19 Jan 2015
- Medium
- Build: staging
- # 5453
- Diff
- larsgrefer:patch-2
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Using the HTML 5 placeholder attribute for the search box when possible and setting the type attribute to 'search' instead of 'text'
jissues-bot
- | Labels |
Added:
?
|
||
@larsgrefer i have send you a CS PR against your branche.
@nternetinspired did you a test or code review? If it is a test can you add it here? http://issues.joomla.org/tracker/joomla-cms/5453
Thanks to both here!
| Category | ⇒ | Search |
@larsgrefer can you check Chorme I think it supports it also atm we don't use placeholder for chrome.
i will mark it successful if we have a review for chrome 
Chorme supports it: http://caniuse.com/#feat=input-placeholder
Can you add it to the check? maybe also Safari?
@larsgrefer i have just add a patch to add safari and chrome.
larsgrefer#2
If we get this in i can mark the successful test. Thanks!
@zero-24 according to http://caniuse.com/#feat=input-placeholder Chrome supports the placeholder attribute since version 4 (January 2010) and Safari since version 5 (june 2010)
I thought it's not necessary to consider browsers which support the attribute for such a long time.
if we should consider them please check your patch larsgrefer#2 to use the correct versions, then il merge it into this pull-request
| Status | Pending | ⇒ | Ready to Commit |
Thanks @larsgrefer moving this here to RTC since it is tested by me and @nternetinspired
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5453.
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-19 22:49:09 |
| Labels |
Removed:
?
|
||
Good improvement @larsgrefer. Thanks.