[#5450] - Wrapping feed-link elements with span instead of h5
- Closed
- 26 Dec 2014
- Medium
- Build: staging
- # 5450
- Diff
- larsgrefer:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Declaring feed-links as h5 is semantically incorrect and causes them to be displayed bold and too much space in between
jissues-bot
- | Labels |
Added:
?
|
||
What is the source of your statement "semantically incorrect"
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5450.
Note: While it is conforming to include heading elements (e.g. h1) inside li elements, it likely does not convey the semantics that the author intended. A heading starts a new section, so a heading in a list implicitly splits the list into spanning multiple sections.
http://www.w3.org/TR/html5/grouping-content.html#the-li-element
Thank you
On 17 December 2014 at 14:24, Lars Grefer notifications@github.com wrote:
Note: While it is conforming to include heading elements (e.g. h1)
inside li elements, it likely does not convey the semantics that the author
intended. A heading starts a new section, so a heading in a list implicitly
splits the list into spanning multiple sections.
http://www.w3.org/TR/html5/grouping-content.html#the-li-element—
Reply to this email directly or view it on GitHub
#5450 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
losedk
- 
Already one test OK on issues. Adding mine and merging. Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-26 11:04:00 |
For testers: This is for the feed module.
Make sure the changed output looks fine in different templates.