Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5448] - Remove noscript and head blocks from HTML. Plus new unit tests.

? Success

User tests: Successful: Unsuccessful:

avatar chrisdavenport
chrisdavenport
16 Dec 2014

Added a couple more blocks that should be removed from HTML by the parser before indexing. Also added more unit tests to cover existing behaviour as well as this new behaviour.

To test, try using Smart Search to index an article containing <noscript> and <head> blocks and make sure that any text between the start and end tags is not searchable. You should set your editor to "none" because the editor might remove those tags anyway.

avatar chrisdavenport chrisdavenport - open - 16 Dec 2014
avatar jissues-bot jissues-bot - change - 16 Dec 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 17 Dec 2014

@chrisdavenport is any testing required? Or are we fine as the Travis (unit tests) pass?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5448.
avatar smz
smz - comment - 17 Dec 2014

@test success (for the front-end part of the PR. Unable to test test-units)

avatar smz smz - test_item - 17 Dec 2014 - Tested successfully
avatar brianteeman brianteeman - change - 17 Dec 2014
Category ⇒ Search Unit Tests
avatar chrisdavenport
chrisdavenport - comment - 3 Jan 2015

@zero-24 Ideally, if you can test as described above then that should be fine. We'll have two successful tests and the PR can be merged. There is no need to test the tests and Travis has done that for us (although code review is always welcome).

avatar roland-d roland-d - change - 8 Jan 2015
Status Pending ⇒ Ready to Commit
avatar roland-d
roland-d - comment - 8 Jan 2015

@test: Works as described.

avatar roland-d roland-d - test_item - 8 Jan 2015 - Tested successfully
avatar ronnikc
ronnikc - comment - 8 Jan 2015

@test: Works :)

avatar roland-d roland-d - change - 8 Jan 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-01-08 21:20:12
avatar roland-d roland-d - close - 8 Jan 2015

Add a Comment

Login with GitHub to post a comment