? Failure

User tests: Successful: Unsuccessful:

avatar alikon
alikon
16 Dec 2014

Purpose

Speed up the process of benchmarking SQL queries executed by a Joomla! page with tools like mysqlslap, pgbench, etc..., writing a file with the extecuted query for the page visited

How it works

Add a parameter (disabled for default) to the logging tab: Log extecuted SQL
pluginsystemdebug

When enabled it write a file to the logs folder named:
sitename_alias+id for frontend
sitename_option_view_layout for administration side

avatar alikon alikon - open - 16 Dec 2014
avatar jissues-bot jissues-bot - change - 16 Dec 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 16 Dec 2014
Category SQL
avatar zero-24
zero-24 - comment - 16 Dec 2014

@alikon please move all { into the next line.

avatar brianteeman
brianteeman - comment - 16 Dec 2014

Please alpha sort the language strings

avatar alikon
alikon - comment - 18 Dec 2014

i've corrected the languages typos and the { fix but still having travis issues with tabs and spaces
can i ask your help on this?

avatar smz
smz - comment - 19 Dec 2014

@alikon Nicola, the main problem here is that you are using spaces for indentation, while the Joomla coding style requires the usage of tabs. What editor are you using? Doesn't it allows you to visualize "non printable" characters and whitespaces? Do you have the possibility to use regular expressions in search/replace or at least to globally substitute a given number of spaces into a single tab?

Then there are minor things, like spaces required between symbols and assignment operators, blank lines before comments, etc...

Also be sure that there are no extra spaces or tabs at end-of-line

avatar smz
smz - comment - 19 Dec 2014

P.S.: If you are on Windows Notepad++ is a very good choice IMHO...

avatar smz
smz - comment - 19 Dec 2014

@alikon If you are in deep s**t, send me the files by mail at smz (at) smz (dot) it and I'll try to give them a clean-up and then send them back to you. In case send them inside a .zip or .rar archive (or tar.gz or whatever...)

avatar richard67
richard67 - comment - 20 Dec 2014

What I can see in the diff is that empty lines have been removed, which are required by the style guide, as far as I know. So maybe the editor is ok, but should not be adjusted to remove empty lines?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5445.
avatar zero-24
zero-24 - comment - 22 Dec 2014

@alikon i have fix codestyle here: alikon#2 Please comment and merge there so we can move this forward.

Other issues are:

  • using of JRequest
$file = JRequest::getVar('option') . JRequest::getVar('view') . JRequest::getVar('layout') . '.sql';
  • the function name
protected function write2file()

maybe we need to change it to something more speaking :smile:

avatar zero-24
zero-24 - comment - 22 Dec 2014

using of JRequest

IIRC we should use something linke this here:

$input = JFactory::getApplication()->input;
$file  = $input->get('option') . $input->get('view') . $input->get('layout') . '.sql';

https://docs.joomla.org/Retrieving_request_data_using_JInput

avatar alikon alikon - reference | - 23 Dec 14
avatar alikon
alikon - comment - 23 Dec 2014

@smz thx a lot for your offer, i'll send you
@zero-24 i've poor fantasy for naming...

avatar zero-24
zero-24 - comment - 23 Dec 2014

@Bakual @wilsonge @roland-d can someone restart the travis job to fix the last CS issue fixed here: #5498

avatar roland-d
roland-d - comment - 23 Dec 2014

@zero-24 Job has been restarted.

avatar zero-24
zero-24 - comment - 23 Dec 2014

:+1:

avatar roland-d
roland-d - comment - 6 Jan 2015

@test: functionality works as expected, however the option Log almost everything is gone. Please update your PR against latest staging.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5445.
avatar roland-d roland-d - test_item - 6 Jan 2015 - Tested unsuccessfully
avatar alikon
alikon - comment - 14 Feb 2015

@roland-d updated

avatar roland-d
roland-d - comment - 14 Feb 2015

@alikon Sorry to say but the PR can't be applied, I get the following errors:

rror: patch failed: administrator/language/en-GB/en-GB.plg_system_debug.ini:1
error: administrator/language/en-GB/en-GB.plg_system_debug.ini: patch does not apply
error: patch failed: plugins/system/debug/debug.php:3
error: plugins/system/debug/debug.php: patch does not apply
error: patch failed: plugins/system/debug/debug.xml:3
error: plugins/system/debug/debug.xml: patch does not apply

This means your files our out-of-sync with the current staging.

avatar alikon
alikon - comment - 6 Apr 2015

close as per #6202

avatar alikon alikon - change - 6 Apr 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-04-06 09:12:46
avatar alikon alikon - close - 6 Apr 2015

Add a Comment

Login with GitHub to post a comment