User tests: Successful: Unsuccessful:
Speed up the process of benchmarking SQL queries executed by a Joomla! page with tools like mysqlslap, pgbench, etc..., writing a file with the extecuted query for the page visited
Add a parameter (disabled for default) to the logging tab: Log extecuted SQL
When enabled it write a file to the logs folder named:
sitename_alias+id for frontend
sitename_option_view_layout for administration side
Labels |
Added:
?
|
Category | ⇒ | SQL |
Please alpha sort the language strings
i've corrected the languages typos and the { fix but still having travis issues with tabs and spaces
can i ask your help on this?
@alikon Nicola, the main problem here is that you are using spaces for indentation, while the Joomla coding style requires the usage of tabs. What editor are you using? Doesn't it allows you to visualize "non printable" characters and whitespaces? Do you have the possibility to use regular expressions in search/replace or at least to globally substitute a given number of spaces into a single tab?
Then there are minor things, like spaces required between symbols and assignment operators, blank lines before comments, etc...
Also be sure that there are no extra spaces or tabs at end-of-line
P.S.: If you are on Windows Notepad++ is a very good choice IMHO...
What I can see in the diff is that empty lines have been removed, which are required by the style guide, as far as I know. So maybe the editor is ok, but should not be adjusted to remove empty lines?
@alikon i have fix codestyle here: alikon#2 Please comment and merge there so we can move this forward.
Other issues are:
$file = JRequest::getVar('option') . JRequest::getVar('view') . JRequest::getVar('layout') . '.sql';
protected function write2file()
maybe we need to change it to something more speaking
using of JRequest
IIRC we should use something linke this here:
$input = JFactory::getApplication()->input;
$file = $input->get('option') . $input->get('view') . $input->get('layout') . '.sql';
https://docs.joomla.org/Retrieving_request_data_using_JInput
@test: functionality works as expected, however the option Log almost everything is gone. Please update your PR against latest staging.
@alikon Sorry to say but the PR can't be applied, I get the following errors:
rror: patch failed: administrator/language/en-GB/en-GB.plg_system_debug.ini:1
error: administrator/language/en-GB/en-GB.plg_system_debug.ini: patch does not apply
error: patch failed: plugins/system/debug/debug.php:3
error: plugins/system/debug/debug.php: patch does not apply
error: patch failed: plugins/system/debug/debug.xml:3
error: plugins/system/debug/debug.xml: patch does not apply
This means your files our out-of-sync with the current staging.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-06 09:12:46 |
@alikon please move all
{
into the next line.