Feeling Lucky
?
[#5443] - JForm Combo Field HTML/Syntax Error
- Closed
- 17 Dec 2014
- Medium
- Build: master
- # 5443
Related to
# 5451
Steps to reproduce the issue
libraries/joomla/form/fields/combo.php line 45
Incorrect
' class=combobox"' . $this->class . '"'
Correct
' class="combobox' . $this->class . '"'
(notice 1st double quote)
System information
- Joomla 3.0 - Correct,
- Joomla 3.1 - Correct,
- Joomla 3.2 - Incorrect,
- Joomla 3.3 - Incorrect.
Additional comments
Obviously the late double quote can potentially cause all kinds of broken HTML problems. Some browser examples I've encountered:
<input type="text" autocomplete="off" btn-group-yesno"="" class="combobox"btn-group" value="1">
<input type="text" autocomplete="off" class="combobox"form-control"" value="">
bassmanpaul
- comment
- 17 Dec 2014
brianteeman
- | Status | New | ⇒ | Closed |
| Rel_Number | ⇒ | 5451 | |
| Relation Type | ⇒ | Related to |
zero-24
- | Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-17 08:48:16 |
| Labels |
Added:
?
|
||
Since you know what to change, can you create a Pull Request?
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests explains how you can do that using the GitHub UI.