User tests: Successful: Unsuccessful:
Fixes #5270 issue.
Labels |
Added:
?
|
Labels |
Added:
?
|
Category | ⇒ | Templates (admin) |
Rel_Number | ⇒ | 5270 | |
Relation Type | ⇒ | Related to |
Works for me in LTR and RTL
@infograf768 I thought that was the intention?
On 3 Jan 2015 07:56, "infograf768" notifications@github.com wrote:
This patch does not keep the image proportions. It cuts it.
[image: screen shot 2015-01-03 at 08 48 37]
https://cloud.githubusercontent.com/assets/869724/5601904/5d898670-9326-11e4-916b-0c52ecdbcdcd.pngoriginal image:
[image: apple]
https://cloud.githubusercontent.com/assets/869724/5601905/6ca25632-9326-11e4-843a-2859973b3264.jpg—
Reply to this email directly or view it on GitHub
#5432 (comment).
Not as we discussed it previously.
#5270 (comment)
This solution
#5335 (comment)
scales the image to fit.
TBH, I think that people who want to add their logo to Isis should just create a correct sized image... at least with the correct proportions.
My intention was just to cut the image with this fix. But which solution do you think is better in this case?
I am in favour of keeping proportions. A cut off image may not have any use at all imho.
@test OK
It fixes the original toolbar position issue.
Test OK
The toolbar is now like excepted. The image is css resized to width: 143px and the height was cropped from bottom.
@victorparanhos Please look at my pull request for your repository:
victorparanhos#2
Status | Pending | ⇒ | Information Required |
Moving to Information Required
until @victorparanhos get a chance to review the PR by @Julia-Mi
victorparanhos#2
Hello @victorparanhos
Thank you for your contribution.
The last comment here was on June 12th. Can you please follow-up on this issue?
Thanks for understanding!
Status | Information Required | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-16 10:52:11 |
Closed_By | ⇒ | brianteeman |
As it has been over a month since the request for follow up I am closing this at this time - it can always be reopened
Think you are missing the rtl less file