? Success
Related to # 5270

User tests: Successful: Unsuccessful:

avatar victorparanhos
victorparanhos
15 Dec 2014

Fixes #5270 issue.

avatar victorparanhos victorparanhos - open - 15 Dec 2014
avatar jissues-bot jissues-bot - change - 15 Dec 2014
Labels Added: ?
avatar jissues-bot jissues-bot - change - 15 Dec 2014
Labels Added: ?
avatar losedk
losedk - comment - 15 Dec 2014

Think you are missing the rtl less file

avatar victorparanhos
victorparanhos - comment - 15 Dec 2014

@losedk But I haven't modified anything on rtl less file. It was modified by generatecss...

avatar brianteeman brianteeman - change - 15 Dec 2014
Category Templates (admin)
avatar brianteeman brianteeman - change - 15 Dec 2014
Rel_Number 5270
Relation Type Related to
avatar brianteeman
brianteeman - comment - 2 Jan 2015

Works for me in LTR and RTL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5432.
avatar brianteeman brianteeman - test_item - 2 Jan 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 3 Jan 2015

This patch does not keep the image proportions. It cuts it.
screen shot 2015-01-03 at 08 48 37

original image:

apple

avatar brianteeman
brianteeman - comment - 3 Jan 2015

@infograf768 I thought that was the intention?
On 3 Jan 2015 07:56, "infograf768" notifications@github.com wrote:

This patch does not keep the image proportions. It cuts it.
[image: screen shot 2015-01-03 at 08 48 37]
https://cloud.githubusercontent.com/assets/869724/5601904/5d898670-9326-11e4-916b-0c52ecdbcdcd.png

original image:

[image: apple]
https://cloud.githubusercontent.com/assets/869724/5601905/6ca25632-9326-11e4-843a-2859973b3264.jpg


Reply to this email directly or view it on GitHub
#5432 (comment).

avatar infograf768
infograf768 - comment - 3 Jan 2015

Not as we discussed it previously.
#5270 (comment)

#5330 (comment)

This solution
#5335 (comment)
scales the image to fit.

avatar infograf768
infograf768 - comment - 3 Jan 2015

TBH, I think that people who want to add their logo to Isis should just create a correct sized image... at least with the correct proportions.

avatar victorparanhos
victorparanhos - comment - 5 Jan 2015

My intention was just to cut the image with this fix. But which solution do you think is better in this case?

avatar infograf768
infograf768 - comment - 5 Jan 2015

I am in favour of keeping proportions. A cut off image may not have any use at all imho.

avatar anibalsanchez anibalsanchez - test_item - 15 Jan 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 15 Jan 2015

@test OK

It fixes the original toolbar position issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5432.
avatar joomla-agency
joomla-agency - comment - 14 Mar 2015

Test OK
The toolbar is now like excepted. The image is css resized to width: 143px and the height was cropped from bottom.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5432.
avatar joomla-agency joomla-agency - test_item - 14 Mar 2015 - Tested successfully
avatar Julia-Mi
Julia-Mi - comment - 14 Mar 2015

@victorparanhos Please look at my pull request for your repository:
victorparanhos#2

avatar zero-24 zero-24 - change - 11 Jun 2015
Status Pending Information Required
avatar zero-24
zero-24 - comment - 11 Jun 2015

Moving to Information Required until @victorparanhos get a chance to review the PR by @Julia-Mi
victorparanhos#2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5432.

avatar roland-d
roland-d - comment - 12 Dec 2015

Hello @victorparanhos

Thank you for your contribution.

The last comment here was on June 12th. Can you please follow-up on this issue?

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5432.

avatar brianteeman brianteeman - change - 16 Jan 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-01-16 10:52:11
Closed_By brianteeman
avatar brianteeman brianteeman - close - 16 Jan 2016
avatar brianteeman
brianteeman - comment - 16 Jan 2016

As it has been over a month since the request for follow up I am closing this at this time - it can always be reopened


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5432.

Add a Comment

Login with GitHub to post a comment