Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5405] - Fixed SQL query (Ref #5307)

? Success
Referenced as Related to: # 5307

User tests: Successful: Unsuccessful:

avatar subtext
subtext
11 Dec 2014

Fixed an issue causing admin user list to be incorrectly filtered for actived state.Because the field ‘activation’ is defined as VARCHAR in MySQL, the integer zero returns an incorrect result. Casting zero as a string in the SQL query corrects the issue.

avatar subtext subtext - open - 11 Dec 2014
avatar jissues-bot jissues-bot - change - 11 Dec 2014
Labels Added: ?
avatar alikon
alikon - comment - 11 Dec 2014

@test success
on postgres without this PR you'll get a Database error

query failed (error # %s): %s SQL=SELECT COUNT(*) FROM "#_users" AS a WHERE a.activation IN ('', 0)

p.s
@roland-d fyi
i've already submitted this one #5385 on the same file for a similar issue

avatar alikon alikon - test_item - 12 Dec 2014 - Tested successfully
avatar brianteeman brianteeman - change - 12 Dec 2014
Category ⇒ SQL
avatar waader
waader - comment - 15 Dec 2014

@test works!

@alikon filtering on "registration date" in the user manager also throws an sql error in postresql. Maybe you could have a look at it.

avatar waader waader - test_item - 15 Dec 2014 - Tested successfully
avatar zero-24 zero-24 - change - 15 Dec 2014
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 15 Dec 2014

RTC Thanks too all!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5405.
avatar brianteeman brianteeman - change - 15 Dec 2014
Labels Added: ?
avatar alikon
alikon - comment - 15 Dec 2014

@waader sure i'll give it a look

avatar alikon
alikon - comment - 15 Dec 2014

@waader i've made a new one #5436 wich include the #5385 (closed) plus your last report on filtering on registration date

avatar zero-24 zero-24 - close - 17 Dec 2014
avatar wilsonge wilsonge - close - 17 Dec 2014
avatar wilsonge wilsonge - change - 17 Dec 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-12-17 13:15:28
avatar wilsonge
wilsonge - comment - 17 Dec 2014

And merged. Thanks guys!

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment