? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
11 Dec 2014

After merging #5338, we get 2 errors:
[11-Dec-2014 07:35:44 UTC] PHP Notice: Undefined property: ModulesModelModule::$typeAlias in /Applications/MAMP/htdocs/trunkgitnew/libraries/legacy/model/admin.php on line 216

and

[11-Dec-2014 07:27:19 UTC] PHP Notice: Undefined property: MenusModelItem::$typeAlias in /Applications/MAMP/htdocs/trunkgitnew/libraries/legacy/model/admin.php on line 216

This PR solves them.

avatar infograf768 infograf768 - open - 11 Dec 2014
avatar jissues-bot jissues-bot - change - 11 Dec 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 11 Dec 2014

To test, use the batch function for menu items and for modules

avatar pe7er
pe7er - comment - 11 Dec 2014

I cannot reproduce the error that PR #5338 should give.

  • Tested on current Joomla! 3.4.0-dev before applying PR #5338 Menus > Australian Parks selected some items, Batch, Moved menu items to other menu.

Extensions > Module Manager
selected some items, Batch, Moved some modules to other module positions.

Expected: no PHP Notice errors
Result: no errors

  • Applied patch #5338 "JModelAdmin: Batch optimizations" and tested: Menus > Australian Parks selected some items, Batch, Moved menu items to other menu.

Extensions > Module Manager
selected some items, Batch, Moved some modules to other module positions.

Expected: "PHP Notice: Undefined property: ModulesModelModule:" errors
Result: no errors

My PHP Version 5.4.35,
error_reporting 32767 (in PHP5.4 this is "E_ALL")

avatar infograf768
infograf768 - comment - 11 Dec 2014

Look at the server logs, not on the page

avatar waader
waader - comment - 11 Dec 2014

@test works!

avatar Kubik-Rubik
Kubik-Rubik - comment - 11 Dec 2014

Tested successfully, thank you @infograf768!

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5395.

avatar Kubik-Rubik Kubik-Rubik - test_item - 11 Dec 2014 - Tested successfully
avatar Kubik-Rubik Kubik-Rubik - alter_testresult - 11 Dec 2014 - waader: Tested successfully
avatar Kubik-Rubik Kubik-Rubik - change - 11 Dec 2014
Status Pending Ready to Commit
avatar infograf768 infograf768 - close - 11 Dec 2014
avatar infograf768 infograf768 - change - 11 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-11 10:24:58

Add a Comment

Login with GitHub to post a comment