[#5392] - Removed index.html, prepared for installation pack
- Closed
- 11 Dec 2014
- Medium
- Build: staging
- # 5392
- Diff
- schnuti:patch-5
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As the index.html files have bin removed should those files be removed from the manifest files.
Not urgent since it only gives an error when trying to (re-)install with an installation package.
I tested uninstall and discover and got no messages. Uninstall removed an existing index.html
without any message even after I removed it from the manifest file.
In addition I prepared for an installation package.
- added method="upgrade"
- changed the language to be loaded from a language folder language/en-GB/ to get a translated description after installation.
If this is accepted all manifests should be edited at least when they get edited anyway.
I choose this as an example since it is a new plugin, I think disabled by default and could be uninstalled in a lot of Joomla use cases.
jissues-bot
- | Labels |
Added:
?
|
||
It makes no sense to change the manifest if the ini files are not ALSO in the language folder IN the extension.
We already did that for a few extensions in core and this is forcing us to update the ini included in the extension as well as the one in the core languages when an update is necessary.
===> Which makes me think we should check if this has been done after recent changes (see the templates for example)
Closing this as not appropriate for core.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-11 08:27:52 |
Sorry, it makes no sence to store the language files in the extension. This would mean a new index.html problem. A lot of unused language files, as all specific language folders would be copied, not only the installed ones. If only the en-GB folder is included, you'll have en-GB in the extension folder and the other ones in the old "standard" folders. Would be very confusing, att least for me.
This change makes no need to change handling of language files in the core, but open ups for creation of installation/update packs if/when you want it. You need the language folder as little as you need the two language files in the extension folder.
Why not prepare for separation of extensions where it do not change any existing workflow?
As the index.html has bin physically removed, you should remove them from the manifests. Maybe you have a batch method to remove lines. I don't - only replace.
@schnuti Good changes, we should update all manifest files of the core like this!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5392.