? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
10 Dec 2014

yep.

avatar okonomiyaki3000 okonomiyaki3000 - open - 10 Dec 2014
avatar jissues-bot jissues-bot - change - 10 Dec 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 10 Dec 2014

I'm fine with removing the index files from our own libraries.
@nikosdion Are you going to remove index.html from fof? If so that could be done already, if not they should stay
@mbabker Do you remember if we added the index.html files to the other libraries (like phpass, idn stuff) ourself?

avatar Hackwar
Hackwar - comment - 10 Dec 2014

We added them all ourselfs. I would simply remove them. In worst case, they would be added back in with the next release of an extension, but I doubt that.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 10 Dec 2014

CodeMirror normally has a bunch of html files that are meant to show demos and stuff. I stripped them out in the latest update.

avatar nikosdion
nikosdion - comment - 10 Dec 2014

@Bakual You can remove them from the Joomla! staging branch and I'll also remove them from the FOF repository.

avatar nikosdion nikosdion - reference | 322e346 - 10 Dec 14
avatar Bakual Bakual - close - 10 Dec 2014
avatar Bakual Bakual - reference | 315d234 - 10 Dec 14
avatar Bakual Bakual - merge - 10 Dec 2014
avatar Bakual Bakual - close - 10 Dec 2014
avatar Bakual Bakual - change - 10 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-10 10:38:32
avatar Bakual
Bakual - comment - 10 Dec 2014

Thanks!

avatar brianteeman brianteeman - change - 10 Dec 2014
Category Code style
avatar Bakual Bakual - change - 11 Dec 2014
Milestone Added:
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 12 Dec 2014

Add a Comment

Login with GitHub to post a comment