[#5376] - Update user.php
- Closed
- 26 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 5376
- Diff
- luis0076:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
With aruba italian provider when you digit wrong password you receive 404 error. With this patch the 404 error disapear
jissues-bot
- | Labels |
Added:
?
|
||
@zero-24 It's right. You only need to test that login still works again. You can test the patch at http://www.marangon.com/web/ using the login module. Without this patch any exception about the login method generates a 404 error in joomla. I found in internet a lot of people that have the 404 error in login operation but they didn't know why.
| Category | ⇒ | Authentication Front End |
| Easy | No | ⇒ | Yes |
Works. No 404 error, joomla error message appears.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5376.
The code quality is NOT OK. This patch should not be merged in the current state.
Replication instruction are also very vague.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5376.
| Status | Pending | ⇒ | Information Required |
In general we do need to catch exceptions from the login method and properly enqueue the error message. The catch block should call $app->enqueueMessage(JText::_('ERROR_MESSAGE')); (replace ERROR_MESSAGE with a proper language key) instead.
@luis0076 could you please update this PR?
| Status | Information Required | ⇒ | Pending |
Set back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5376.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-26 10:55:34 |
| Closed_By | ⇒ | luis0076 |
@luis0076 have you any specific way to reproduce the Problem and / or test the patch?
If i see it correct we only need to test that the login still works?