? Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
9 Dec 2014

This solves an issue with installation showing "undefined" alert messages reported in #5331. Issue was introduced by me in #5257

Description

Basically the installation process is not adding alert message type translations properly (Before using any message type you have to add the JS translation with JText::script('MESSAGE'); , JText::script('ERROR');, etc.). If not the message is not really translated. This is discovered after removing the jQuery dependency in #5257

Basically what I'm doing now is testing that the translation of the message type has been defined and if not we skip adding the alert heading. This preserves exactly the previous behavior. Of course it would be better to add that message types translations to the installer but I think this fix makes sense anyway if third part extension developers forget to add the translation for example.

Backward compatibility

This PR has no B/C issues. In fact it fixes one.

Test

On the first Joomla installation screen of Joomla do not fill any fields and press the Next button. You should see the undefined alert message titles. After applyting the patch no titles should be visible.

avatar phproberto phproberto - open - 9 Dec 2014
avatar jissues-bot jissues-bot - change - 9 Dec 2014
Labels Added: ?
avatar wilsonge
wilsonge - comment - 9 Dec 2014

Would it not be better to keep behaviour the same as JApplicationCms::enqueueMessage() and add a default of a message type if none given?

avatar dgt41
dgt41 - comment - 9 Dec 2014

I also prefer to fix this in the server side, :+1: from me @wilsonge

avatar waader
waader - comment - 9 Dec 2014

@test works!

Resolves the issue with the undefined message in #5331.

avatar dgt41
dgt41 - comment - 9 Dec 2014

@test success against #5099
before:
screen shot 2014-12-09 at 5 42 24

After:
screen shot 2014-12-09 at 5 43 18

avatar infograf768
infograf768 - comment - 10 Dec 2014

Works fine. Merging.

avatar infograf768 infograf768 - close - 10 Dec 2014
avatar infograf768 infograf768 - change - 10 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-10 08:27:22
avatar phproberto
phproberto - comment - 10 Dec 2014

@wilsonge as I said this fix is not incompatible with anything we want to do in the server side.

Add a Comment

Login with GitHub to post a comment