[#5346] - Login Module - Uses current URL in the action attribute of the form element
- Closed
- 11 Dec 2014
- Medium
- Build: staging
- Easy Test
- # 5346
- Diff
- Kubik-Rubik:mod_login-form-action-url
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
Problem is described here: #5345
How to test
Try to login and logout on several pages of the Joomla! installation, especially on pages without menu entry (e.g. category of an article without menu entry), all processes should work properly. To see the change, open the source code of such a page and compare the URL in the action attribute of the form.
jissues-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Front End Modules |
| Easy | No | ⇒ | Yes |
This does not work here when sef is off.
@wilsonge I would use the action attribute for consistency.
@infograf768 What exactly does not work? If SEF is off it should just use the index.php URL as it did before (without query parameters).
Before the PR, we would get the full non-sef path when there was a menu item for the page displayed.
Now, we only get an index.php
@infograf768 Okay, got it! It would not have an influence on the functionality. Anyway, changed it to set the action attribute value to the called URL. In this case we actually would not require the action attribute at all (as @wilsonge said) but I would still like to have it in.
| Milestone |
Added: |
||
Merging, thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-11 15:54:39 |
Do we actually need an action attribute? It's not compulsory in HTML5 and if we're always sending the user to the same page anyway......?