?
Referenced as Pull Request for: # 6004
avatar AndyGaskell
AndyGaskell
6 Dec 2014

Steps to reproduce the issue

  1. Log into Joomla admin
  2. Go to "Menus" -> "Main Menu" -> "Add New Menu Item"
  3. For the "Menu Item Type" field select "Menu Heading"
  4. Click on the "Link Type" tab, it is blank.

Expected result

The "Link Type" tab for other menu item types lets you set "Link Title Attribute", "Link CSS Style", "Link Iimage" ans "Add Menu Item".
In Joomla! 2.5.27 these properties were set-able for "Menu Heading" menu item types.

Actual result

The "Link Type" tab is blank. I would have expected to be able to set the same attributes for "Menu Heading" menu items types.

System information (as much as possible)

First noticed in Joomla! 3.3.6 but also seen in Joomla! 3.3.1

System Information
PHP Built On Linux penguin.directrouter.co.uk 2.6.32-531.23.3.lve1.2.66.el6.x86_64 #1 SMP Fri Sep 12 10:57:40 EDT 2014 x86_64
Database Version 5.6.21
Database Collation utf8_general_ci
PHP Version 5.4.32
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 3.3.6 Stable [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0

Additional comments

Looking at the documentation at https://docs.joomla.org/Help33:Menus_Menu_Item_Menu_Item_Heading and the screen grab there, these tabs have evolved a bit.

If folk think this is a fair bug I'm happy to try and code up a fix.

I checked my Apache logs and didn't see any warnings.

I noticed the FireBug console puts out 2 lines...
Use of getAttributeNode() is deprecated. Use getAttribute() instead. mootools-core.js (line 108)
content is null tab-events.js (line 40)

I googled this and didn't really find anyone else with the same issues. Perhaps not many folk use the combination of "Menu Heading" and "Link Type" tab.

This is the first bug I've submitted, hope this is ok.

Thanks!

screen shot 2014-12-06 at 00 20 35
screen shot 2014-12-06 at 00 20 32

avatar AndyGaskell AndyGaskell - open - 6 Dec 2014
avatar AndyGaskell AndyGaskell - change - 6 Dec 2014
The description was changed
avatar AndyGaskell
AndyGaskell - comment - 6 Dec 2014

just tidied it up a bit

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5332.

avatar infograf768
infograf768 - comment - 6 Dec 2014

I agree that this should have some more parameters
css class, image, image + text

avatar AndyGaskell
AndyGaskell - comment - 6 Dec 2014

So, I didn't explain so clearly in the initial note, pretty much as per infograf768's comment, the 4 fields would be...

Link Title Attribute: A text box. An optional, custom description for the title attribute of the menu hyperlink

Link CSS Style: A text box. An optional, custom style to apply to the menu hyperlink

Link Image: A media select box. An optional image to be used with the menu hyperlink

Add Menu Title: A yes/no toggle. If the optional image is added, adds the menu title next to the image. Default is 'Yes.

This would make it the same as other menu types like "Menu Item Alias", "Single Article", "Archived Articles" and, I think most, if not all other menu item types.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5332.

avatar infograf768
infograf768 - comment - 7 Dec 2014

This looks rather easy to instate. We would need though to update the menu module too.

avatar AndyGaskell
AndyGaskell - comment - 8 Dec 2014

I'll have a look at coding this up and testing it.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5332.

avatar brianteeman brianteeman - change - 3 Jan 2015
Labels Added: ?
avatar AndyGaskell AndyGaskell - reference | - 6 Feb 15
avatar AndyGaskell AndyGaskell - reference | - 6 Feb 15
avatar AndyGaskell AndyGaskell - reference | - 6 Feb 15
avatar brianteeman brianteeman - change - 6 Feb 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-02-06 22:14:21
Closed_By brianteeman
avatar brianteeman brianteeman - close - 6 Feb 2015
avatar brianteeman brianteeman - close - 6 Feb 2015
avatar brianteeman
brianteeman - comment - 6 Feb 2015

See #6004


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5332.

Add a Comment

Login with GitHub to post a comment