Great work - thanks - I made a few small comments on the english language file

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5323.

@brianteeman I used the same capitalization as the reCAPTCHA plugin. Yeah, it's inconsistent with the product branding but I had two choices:

• be inconsistent with Joomla!; or
• be inconsistent with reCAPTCHA

Regarding index.html, it is not required by JED for third party extensions. The core plugins still have those files.

The same caps but not the same spelling ;)

re index.html see #3788

On 4 December 2014 at 15:39, Nicholas K. Dionysopoulos <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman I used the same
capitalization as the reCAPTCHA plugin. Yeah, it's inconsistent with the
product branding but I had two choices:

• be inconsistent with Joomla!; or
• be inconsistent with reCAPTCHA

Regarding index.html, it is not required by JED for third party
extensions. The core plugins still have those files.

—
Reply to this email directly or view it on GitHub
#5323 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@test success! I tested with postgresql and mssql on the user registration form.

Could we perhaps include the data-type attribute?

I fixed the language strings and the default theme. I am not sure what you mean regarding the data-type attribute @losedk

@nikosdion Cool!

Included a screenshot from the API documentation:

I think it shouldn't. We have not implemented it for the old reCAPTCHA plugin. Moreover –if I understand it correctly– Google will serve the correct type (image or audio) depending on the user's accessibility settings. I wonder if we have any people with impaired vision who can test it for us using their real world browser settings?

Point taken! :)

@test Almost but there are issues with the captcha responsiveness which you can see if you use Isis and the testing data (or have anything in both left and right columns)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5323.

Correction - the old captcha plugin has the exact same issues. And as you;ve corrected the test I am marking this as a successful test

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5323.

FYI @brianteeman the responsiveness is one part Google problem and one part Joomla! issue. If/when Joomla! switches to Bootstrap 3 this issue will go away. BS3 renders forms differently on extra small widths. Instead of having the label left and the fields to the right it moves the label on top of the fields and this fixes the layout.

Installed the plugin on developer.joomla.org, working fine.

@nikosdion can you disable the CS stuff for the google lib and fix the CS stuff for the new file?

FILE: .../travis/build/joomla/joomla-cms/plugins/captcha/nocaptcha/nocaptcha.php
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
 31 | ERROR | Expected 2 spaces after the longest type
 31 | ERROR | Expected 2 spaces after the longest variable name
 69 | ERROR | Expected 2 spaces after the longest type
 71 | ERROR | Expected 2 spaces after the longest variable name
 86 | ERROR | Expected 2 spaces after the longest type
 86 | ERROR | Expected 2 spaces after the longest variable name
--------------------------------------------------------------------------------

See: https://travis-ci.org/joomla/joomla-cms/jobs/42998686

@nikosdion i have add a CS PR to fix the issues: nikosdion#3

Thank you! I just merged your PR.

Thanks but it looks like i have missed two errors. nikosdion#4 Sorry @nikosdion

There you go, merged :)

thanks Travis is happy now

Thank you! I tested it on developer.joomla.org and everything tested fine.

Awesome! I guess we can set it RTC now that we have tested it on project property and Travis is happy? :)

moving to RTC but i think @Bakual @phproberto @mbabker @dbhurley or others form the PLT need to accept it bevor we can merge this

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5323.

@nikosdion Can you correct the spelling mistake in the english as I commented on github. Once thats done I will set it RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5323.

Thanks for merging that spelling correction

Why add deprecated strings in a new plugin?

@Committer
a new line has to be added in en-GB.install.xml for the new plugin if merged in 3.4.0 beta

@infograf768 Issues fixed thanks to @zero-24's speedy PR :)

Works great!
Looks like we are covered for all these languages;
https://developers.google.com/recaptcha/docs/language